New issue
Advanced search Search tips

Issue 817460 link

Starred by 2 users
Status: Fixed
Owner:
mrefaat@chromium.org
Closed: Mar 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 0
Type: Bug



Sign in to add a comment

ios_chrome_integration_egtests are failing on simulator

Project Member Reported by eugene...@chromium.org, Feb 28 2018 
App Version (from "Chrome Settings > About Chrome"): ToT
iOS Version: 11.3
Device: iPhone6 Plus Simulator

Steps to reproduce: 
1.) Run ios_chrome_integration_egtests

Observed behavior: 
Crash with the following stack:

    frame #0: 0x0000000115e80b85 WebKit`WebKit::WebsiteDataStore::~WebsiteDataStore() + 519
    frame #1: 0x0000000115e80c10 WebKit`WebKit::WebsiteDataStore::~WebsiteDataStore() + 14
    frame #2: 0x0000000115ef2e3f WebKit`-[WKHTTPCookieStore dealloc] + 149
    frame #3: 0x00000001174efa6e libobjc.A.dylib`objc_object::sidetable_release(bool) + 202
    frame #4: 0x00000001033d8ed7 ios_chrome_integration_egtests`web::WKHTTPSystemCookieStore::~WKHTTPSystemCookieStore(this=0x000060000025d3d0) at wk_http_system_cookie_store.mm:58
    frame #5: 0x00000001033d8f05 ios_chrome_integration_egtests`web::WKHTTPSystemCookieStore::~WKHTTPSystemCookieStore(this=0x000060000025d3d0) at wk_http_system_cookie_store.mm:58
    frame #6: 0x00000001033d8f29 ios_chrome_integration_egtests`web::WKHTTPSystemCookieStore::~WKHTTPSystemCookieStore(this=0x000060000025d3d0) at wk_http_system_cookie_store.mm:58
    frame #7: 0x000000010322a0a5 ios_chrome_integration_egtests`net::CookieStoreIOS::~CookieStoreIOS() [inlined] std::__1::default_delete<net::SystemCookieStore>::operator(this=0x00006180003840a8, __ptr=0x000060000025d3d0)(net::SystemCookieStore*) const at memory:2333

Comment 1 by eugene...@chromium.org, Feb 28 2018

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77357f49f14e6d89f81939d68ef8508d0eb07e17

commit 77357f49f14e6d89f81939d68ef8508d0eb07e17
Author: mrefaat <mrefaat@chromium.org>
Date: Fri Mar 09 01:05:25 2018

Fix Crash when closing incognito

WebSiteDataStore crashed during the destructing of WKHTTPCookieStore
The reason:
 WKHTTPCookieStore can't be deleted in IO Thread (undocumented behavior).
The solution:
 Make WKHTTPCookieStore instance in WKHTTPSystemCookieStore as weak, so
 it's not retained in WKHTTPSystemCookieStore and it's deleted/released
 when WebSiteDataStore is deleted.

Bug:  817460 , 816879
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I15b384f41496df6d0af9c550b7b13e67a75d236b
Reviewed-on: https://chromium-review.googlesource.com/955547
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541973}
[modify] https://crrev.com/77357f49f14e6d89f81939d68ef8508d0eb07e17/ios/web/net/cookies/wk_http_system_cookie_store.h
[modify] https://crrev.com/77357f49f14e6d89f81939d68ef8508d0eb07e17/ios/web/net/cookies/wk_http_system_cookie_store.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d85ecf0ef7a0f9d54434feea6f7c65ee63c46e

commit 51d85ecf0ef7a0f9d54434feea6f7c65ee63c46e
Author: mrefaat <mrefaat@chromium.org>
Date: Mon Mar 12 18:56:39 2018

[Merge to 66]Fix Crash when closing incognito

WebSiteDataStore crashed during the destructing of WKHTTPCookieStore
The reason:
 WKHTTPCookieStore can't be deleted in IO Thread (undocumented behavior).
The solution:
 Make WKHTTPCookieStore instance in WKHTTPSystemCookieStore as weak, so
 it's not retained in WKHTTPSystemCookieStore and it's deleted/released
 when WebSiteDataStore is deleted.

Bug:  817460 , 816879
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I15b384f41496df6d0af9c550b7b13e67a75d236b
Reviewed-on: https://chromium-review.googlesource.com/955547
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541973}(cherry picked from commit 77357f49f14e6d89f81939d68ef8508d0eb07e17)
Reviewed-on: https://chromium-review.googlesource.com/959285
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#171}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/51d85ecf0ef7a0f9d54434feea6f7c65ee63c46e/ios/web/net/cookies/wk_http_system_cookie_store.h
[modify] https://crrev.com/51d85ecf0ef7a0f9d54434feea6f7c65ee63c46e/ios/web/net/cookies/wk_http_system_cookie_store.mm

Comment 4 by mrefaat@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)

Comment 5 by mrefaat@chromium.org, Mar 15 2018 

Issue 812233 has been merged into this issue.
►

Sign in to add a comment