Background Fetch defines its own IconDefinition field, to represent icons: https://wicg.github.io/background-fetch/#background-fetch-manager The Manifest specification now defines an ImageResource type: https://w3c.github.io/manifest/#dom-imageresource We should drop our own type and migrate to that instead. I'll propose a spec change for Jake later this week.
Assigning to rayankans@ since he's working on it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/393cb223228c8598a0eb81c128c3215bcfdea13e commit 393cb223228c8598a0eb81c128c3215bcfdea13e Author: Rayan Kanso <rayankans@chromium.org> Date: Wed Jun 06 09:34:05 2018 Replace ManifestIcon w/ManifestImageResource. The WebApp Manifest spec defines the ImageResource dictionary to represent icon. https://w3c.github.io/manifest/#dom-imageresource This CL changes references to ManifestIcon in blink and mojo to ManifestImageResource. TBR=ortuno@chromium.org Bug: 817445 Change-Id: I75783f8fe1f86edb672a97f6d762f713584b88c9 Reviewed-on: https://chromium-review.googlesource.com/1080794 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#564837} [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/shortcut_info.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/shortcut_info_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/webapk/webapk_web_manifest_checker.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/webapk/webapk_web_manifest_checker_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/extensions/bookmark_app_helper_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/installable/installable_manager.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/installable/installable_manager.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/installable/installable_manager_browsertest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/installable/installable_manager_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/chrome/browser/installable/installable_task_queue_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/components/favicon/content/content_favicon_driver.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/components/payments/content/installable_payment_app_crawler.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/browser/manifest/manifest_icon_selector.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/browser/manifest/manifest_icon_selector_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/browser/payments/payment_app_database.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/browser/payments/payment_app_info_fetcher.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/browser/payments/payment_instrument_icon_fetcher.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/browser/payments/payment_instrument_icon_fetcher.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/public/browser/manifest_icon_selector.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/public/common/manifest_struct_traits.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/renderer/manifest/manifest_parser.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/renderer/manifest/manifest_parser.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/content/renderer/manifest/manifest_parser_unittest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/common/manifest/manifest.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/common/manifest/manifest_mojom_traits.cc [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/public/common/manifest/manifest.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/public/common/manifest/manifest.typemap [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/public/common/manifest/manifest_mojom_traits.h [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/public/mojom/manifest/manifest.mojom [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/public/platform/modules/payments/payment_app.mojom [modify] https://crrev.com/393cb223228c8598a0eb81c128c3215bcfdea13e/third_party/blink/renderer/modules/payments/payment_instruments.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faa9c66a513236e7caf1ce0f47ad14271c9ef683 commit faa9c66a513236e7caf1ce0f47ad14271c9ef683 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Jun 11 19:22:29 2018 Add conversion logic from idl ImageResource to mojo ImageResourcePtr Conversion details defines in the spec: https://w3c.github.io/manifest/#imageresource-and-its-members Bug: 817445 Change-Id: I3534556d3824e090becedcb143309f84c77e42da Reviewed-on: https://chromium-review.googlesource.com/1087457 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#566098} [modify] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/BUILD.gn [add] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/manifest/BUILD.gn [add] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/manifest/OWNERS [add] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/manifest/image_resource.idl [add] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/manifest/image_resource_type_converters.cc [add] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/manifest/image_resource_type_converters.h [add] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/manifest/image_resource_type_converters_test.cc [modify] https://crrev.com/faa9c66a513236e7caf1ce0f47ad14271c9ef683/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d02f85c18e9118863a5bc5aff0632bdbe037cd22 commit d02f85c18e9118863a5bc5aff0632bdbe037cd22 Author: Rayan Kanso <rayankans@chromium.org> Date: Thu Jun 21 22:55:18 2018 [Background Fetch] Replace IconDefinition w/ManifestImageResource TBR=jbroman@chromium.org Bug: 817445 Change-Id: I2336b16d2e10a524c176997b75471b8bc8310460 Reviewed-on: https://chromium-review.googlesource.com/1097482 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#569396} [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/browser/background_fetch/background_fetch.proto [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/common/background_fetch/background_fetch_struct_traits_unittest.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/common/background_fetch/background_fetch_types.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/content/common/background_fetch/background_fetch_types.h [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader.h [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_icon_loader_test.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_options.idl [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.h [delete] https://crrev.com/68497996df4bde8b8ee71857c9f160657279b5a8/third_party/blink/renderer/modules/background_fetch/icon_definition.idl [modify] https://crrev.com/d02f85c18e9118863a5bc5aff0632bdbe037cd22/third_party/blink/renderer/modules/modules_idl_files.gni
Comment 1 by na...@chromium.org
, May 3 2018