New issue
Advanced search Search tips

Issue 817436 link

Starred by 0 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Mar 2018
Cc:
omrilio@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Bad shadow placement in overview mode if pressed while animating.

Project Member Reported by sammiequon@chromium.org, Feb 28 2018 
Easier to repro with slow animations turned on.

(1) Enter tablet mode, then overview mode, with one window open.
(2) While window is still animating to initial position, click it.

What is the expected result?
No shadow and no rounded edges.

What happens instead?
Rounded edges appear, and shadow does, and is placed in the wrong spot.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02c8b958d3d10b4d442d589c409809b2c2e9b642

commit 02c8b958d3d10b4d442d589c409809b2c2e9b642
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Mar 02 00:35:09 2018

overview: Fix shadow placed in the wrong spot.

Bug caused by press while still animation, then shadow gets applied after
animation end. Fix this by canceling animation watching if press event.

Test: manual
Bug:  817436 
Change-Id: Icd1677d4854db8fc6b5ec12c7c71d1a76e955ea6
Reviewed-on: https://chromium-review.googlesource.com/941721
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540374}
[modify] https://crrev.com/02c8b958d3d10b4d442d589c409809b2c2e9b642/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/02c8b958d3d10b4d442d589c409809b2c2e9b642/ash/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/02c8b958d3d10b4d442d589c409809b2c2e9b642/ash/wm/overview/window_selector_item.cc

Comment 2 by sammiequon@chromium.org, Mar 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment