New issue
Advanced search Search tips

Issue 817429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

There should be a clearly visible separator for "Navigated to..." in the console

Reported by teo8...@gmail.com, Feb 28 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36

Steps to reproduce the problem:
1. open the console and make sure "preserve log" is checked
2. visit a page that logs some shit to the console
3. refresh or click on a link that goes to some other page that also prints stuff to the console
4. 

What is the expected behavior?
In the console output, at the point where it says "Navigated to http://___url___", there should be a clearly distinguishable, easy to spot separation.

And there used to be. I don't remember exactly how it was, I think the text was slightly indented and in italic, I seem to remember there was like a ">" icon at the beginning or something, I'm not sure, but it was easy to spot at a simple glance.

What went wrong?
The line that says "Navigated to: ..." looks exactly like any other line of text output in the console. There is no separator, no extra space above or below, no indentation, NOTHING. 

You have to f***ing READ every line looking for where it says "Navigated to" (assuming there is no console output that says "Navigated to", which would be perfectly possible).

It's pathetic.

Did this work before? Yes not sure but not many versions ago

Chrome version: 64.0.3282.167  Channel: n/a
OS Version: 
Flash Version:
 

Comment 1 by teo8...@gmail.com, Feb 28 2018

Forgot to attach a screenshot
Untitled.png
86.1 KB View Download
Labels: Needs-Bisect Needs-Triage-M64
Cc: susan.boorgula@chromium.org
Labels: Triaged-ET Needs-Feedback
teo8976@ Thanks for the issue.

Tested this issue on Ubuntu 14.04 and Windows 10 on the reported version 64.0.3282.167, latest Stable 64.0.3282.186 and Canary 66.0.3357.0 and unable to reproduce the issue by following the steps given above.

On navigating to amazon.in site and observing the console log, can see that the 'Navigated to ....' is easy to spot.
Attached is the screen cast for reference.

Request you to please check and confirm if anything is missed from our end in triaging the issue.

Also request you to update chrome to the latest version,retry the issue on a new chrome profile without any flags/extensions and update the thread with the observations.

Thanks...
817429.webm
6.9 MB View Download

Comment 4 by alph@chromium.org, Mar 2 2018

Owner: pfeldman@chromium.org
Status: Assigned (was: Unconfirmed)
Pavel, could you please share UX expertise. Do we want to put some extra emphasis onto the Navigated message?

Comment 5 by teo8...@gmail.com, Mar 2 2018

> On navigating to amazon.in site and observing the console log, 
> can see that the 'Navigated to ....' is easy to spot.

LOL that's because in your case there happens to be nothing else in the console than warnings, which are all highlighted in yellow, while the "navigated to" text is not.

But when there is actual output (like from console.log()), as in my screenshot (have you even looked at it??), then the "navigated to" is not easy to spot at all.

Note that, since it contains a url, which is underlined as a link, that *might* help slightly in many cases, BUT, if the console output also contains links, then the "navigated to" definitely becomes an indistinguishable line of text like any other from actual output.
Owner: l...@chromium.org
Yes, we should render it with some very strong background
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ba7b226f82f76aeb3a61116a31cd4ac9272ebc8

commit 0ba7b226f82f76aeb3a61116a31cd4ac9272ebc8
Author: Erik Luo <luoe@chromium.org>
Date: Tue Mar 13 05:00:06 2018

DevTools: restore styles for console navigation and violation messages

DevTools prints console System-type Info-level messages only in 2 cases
- MainFrame navigations "Navigated to ..."
- Dumping size of large Common.Settings that failed to save

This CL sets text color to blue in these cases, and also sets
dark-theme violation text to original warning colors.

Screenshot: https://imgur.com/a/yaIbr

Bug:  817429 
Change-Id: Id3f2c7ad16a3f02b40b4aafe93f5ca3dcf04f4b1
Reviewed-on: https://chromium-review.googlesource.com/955893
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542733}
[modify] https://crrev.com/0ba7b226f82f76aeb3a61116a31cd4ac9272ebc8/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/0ba7b226f82f76aeb3a61116a31cd4ac9272ebc8/third_party/WebKit/Source/devtools/front_end/console/consoleView.css

Comment 8 by l...@chromium.org, Mar 14 2018

Labels: -Needs-Feedback
Status: Fixed (was: Assigned)
Labels: TE-Verified-M67 TE-Verified-67.0.3370.0
Tested this issue on Ubuntu 14.04 on the reported version 64.0.3282.167 and latest Canary 67.0.3370.0.
Able to reproduce this issue on the reported version 64.0.3282.167 and the issue is fixed on the latest Canary 67.0.3370.0.

Can observe that the 'Navigated to...' is in blue color as mentioned in comment #7.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
817429.png
50.5 KB View Download

Sign in to add a comment