New issue
Advanced search Search tips

Issue 817427 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

README.md missing for subresource_filter

Project Member Reported by jkarlin@chromium.org, Feb 28 2018

Issue description

It'd be good to have a readme in the following directories:

components/subresource_filter/
components/url_pattern_index/

Something akin to what's in cache_storage[1] that describes the high-level architecture, ownership of objects, purpose of the major classes, and common idioms used in the code.

[1]https://cs.chromium.org/chromium/src/content/browser/cache_storage/README.md?q=cache_storage/README&sq=package:chromium&l=1
 
Owner: csharrison@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb561365c610a62d276835deacdeb92aee14a787

commit fb561365c610a62d276835deacdeb92aee14a787
Author: Charles Harrison <csharrison@chromium.org>
Date: Mon Mar 19 19:07:46 2018

[subresource_filter] Add some documentation to the README

Added a high level overview as well as descriptions of key components,
with important ownership highlighted.

Bug:  817427 
Change-Id: Iaad43832f08402ca8a7d73708e0f005359d9d31a
Reviewed-on: https://chromium-review.googlesource.com/961269
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544095}
[delete] https://crrev.com/e54ceb298c5dd2a20eb2f0215d25db917465dc87/components/subresource_filter/README
[add] https://crrev.com/fb561365c610a62d276835deacdeb92aee14a787/components/subresource_filter/README.md

Status: Fixed (was: Started)

Sign in to add a comment