New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817423 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Use correct layered icons for dev and beta VR icons

Project Member Reported by mthiesse@chromium.org, Feb 28 2018

Issue description

The placeholder icons we currently use are not using the new dev/beta layered icons and so will look different in VR.

We should use the right icons.
 
Blocking: 768564

Comment 2 by ericde@google.com, Mar 3 2018

Labels: hotlist-vrb-mvp

Comment 3 by sko...@chromium.org, Mar 30 2018

Blocking: -768564
Cc: gordonbrander@chromium.org
Per UX folks, we're not going to use different icons for N and O for text legibility reasons. Also, all of the icons are going to be updated to be slightly larger, again for legibility.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/8367e2e9ede082e97160fbecd61eb9e0774ea5e1

commit 8367e2e9ede082e97160fbecd61eb9e0774ea5e1
Author: Michael Thiessen <mthiesse@google.com>
Date: Wed Apr 11 22:29:12 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa9911ef8937c498c996aa3d508a972f480b57a0

commit fa9911ef8937c498c996aa3d508a972f480b57a0
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Apr 12 01:08:47 2018

Update VR chromium icon

Bug:  817423 
Change-Id: I381e8b98926ffd9c18cf640daf033775e16bcac7
Reviewed-on: https://chromium-review.googlesource.com/1008702
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549984}
[modify] https://crrev.com/fa9911ef8937c498c996aa3d508a972f480b57a0/chrome/android/java/res_vr/drawable-nodpi/daydream_icon_foreground.dd.png

Status: Fixed (was: Assigned)
Labels: Test-Complete
Status: Verified (was: Fixed)
Fix verified in build 657.0.3396.29 beta, looks good.

Sign in to add a comment