When dev console is open, reloading from UI carries user gesture |
|||||||
Issue descriptionChrome Version: 66.0.3358.0 (Developer Build) (64-bit)( What steps will reproduce the problem? (1) Make sure dev console is closed (2) Visit http://googlechromelabs.github.io/web-audio-samples/stress-test/boxes (3) Use the mouse and drag across the window. Blocks will drop. No audio is heard as expected. (4) Close that tab. (5) Open dev console (6) Visit the page and drop blocks. No audio. (Dev console shows warning.) (7) Reload the page. Drop blocks. Audio is heard. No warning in dev console. What is the expected result? No audio is heard due to autoplay policy. What happens instead? I didn't expect reloading the page with dev console open would have any affect on autoplay policy. This makes debugging pretty hard if the open dev console affects the auto play policy in some way.
,
Mar 1 2018
Yes, if you load the page after opening the dev console, it doesn't play. But if you reload it does as I show in my repro steps. On the other hand, http://rtoy.github.io/webaudio-hacks/tests/osc.html starts playing right away without interaction from me. (ToT today). But other examples from http://rtoy.github.io/webaudio-hacks/tests/index.html don't play audio, as expected, even with user interaction. (Because I haven't updated the examples to support user gestures to play.)
,
Mar 16 2018
mlamouri: Any thoughts on my osc.html test in c#2? Autoplay should be consistent and refuse to produce audio here.
,
May 11 2018
I investigated this a little bit and it has nothing to do with Web Audio. What happens is that when the console is opened (via a shortcut), it sets the user gesture flag on the tab. When reloading from the UI, the flag is then set as a navigation user gesture instead of not being set (behaviour without the console open).
,
Jun 9 2018
,
Jun 11 2018
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/decbccdbfc17bd75df40a9c47b24dd80dfea90c0 commit decbccdbfc17bd75df40a9c47b24dd80dfea90c0 Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Mon Jul 23 23:40:49 2018 DevTools: pass parsed message as unique_ptr instead of raw pointer This will allow devtools_session to own parsed message and bind it as a part of a callback. R=dgozman Bug: 817413 Change-Id: I48dc7a12741902603e22233cdd26b6bb97ecf453 Reviewed-on: https://chromium-review.googlesource.com/1145954 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577328} [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/browser_devtools_agent_host.cc [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/browser_devtools_agent_host.h [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/devtools_agent_host_impl.cc [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/devtools_agent_host_impl.h [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/devtools_session.cc [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/devtools_session.h [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/target_registry.cc [modify] https://crrev.com/decbccdbfc17bd75df40a9c47b24dd80dfea90c0/content/browser/devtools/target_registry.h
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd8a9141c0588fd211570c769d82dfa595add19a commit bd8a9141c0588fd211570c769d82dfa595add19a Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Thu Jul 26 01:59:04 2018 DevTools: trigger browser-side reload when devtools is open DevTools should initiate browser-side reload so that reload button doesn't change behavior with and without devtools open. R=dgozman Bug: 817413 Change-Id: Ia69070c82e7ea46e165c485081ab2fe965fae531 Reviewed-on: https://chromium-review.googlesource.com/1107118 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578167} [modify] https://crrev.com/bd8a9141c0588fd211570c769d82dfa595add19a/content/browser/devtools/protocol/page_handler.cc [modify] https://crrev.com/bd8a9141c0588fd211570c769d82dfa595add19a/content/browser/devtools/protocol/page_handler.h [modify] https://crrev.com/bd8a9141c0588fd211570c769d82dfa595add19a/content/browser/devtools/protocol_config.json [modify] https://crrev.com/bd8a9141c0588fd211570c769d82dfa595add19a/third_party/blink/renderer/core/inspector/inspector_page_agent.cc
,
Jul 26
,
Jul 30
I tried today on trunk (70.0.3508.0) and it's working. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mlamouri@chromium.org
, Mar 1 2018