Issue metadata
Sign in to add a comment
|
2D payment request dialog pop-up appears in VR browsing mode |
||||||||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3356.0 OS: Android N Device: Galaxy S8+ VrCore: 1.13.185188193 What steps will reproduce the problem? (1) Go to https://samsunginter.net/examples/payment-request-demo-simple/ (2) Enter VR browsing (3) Click on the "Try it now!" button What is the expected result? payment dialog is suppressed. What happens instead? Payment dialog appears, see screenshot.
,
Mar 6 2018
,
Mar 6 2018
moving to M67 where we will finish up the 2d UI work.
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6243dfe00dab338151a161e582dbf75d72026a40 commit 6243dfe00dab338151a161e582dbf75d72026a40 Author: Ian Vollick <vollick@chromium.org> Date: Thu Mar 08 01:08:53 2018 [vr] Ensure that immersive mode information is correctly propagated We have plumbed knowledge to blink that we are in immersive mode, but a spot was missed: when the preferences are updated, we failed to poll whether we were in immersive mode. The result is that we would often clobber the immersive mode setting. Bug: 817412 Change-Id: I402346a43d3d2214475d93a14208a92cfedfa00d Reviewed-on: https://chromium-review.googlesource.com/953168 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541670} [modify] https://crrev.com/6243dfe00dab338151a161e582dbf75d72026a40/chrome/browser/chrome_content_browser_client.cc
,
Mar 8 2018
,
Mar 8 2018
,
Mar 8 2018
,
Mar 9 2018
,
Mar 10 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/708e98d990abcad327d048240e5eb12f0a03922d commit 708e98d990abcad327d048240e5eb12f0a03922d Author: Ian Vollick <vollick@chromium.org> Date: Mon Mar 12 12:55:59 2018 [vr] Ensure that immersive mode information is correctly propagated We have plumbed knowledge to blink that we are in immersive mode, but a spot was missed: when the preferences are updated, we failed to poll whether we were in immersive mode. The result is that we would often clobber the immersive mode setting. Bug: 817412 Change-Id: I402346a43d3d2214475d93a14208a92cfedfa00d Reviewed-on: https://chromium-review.googlesource.com/953168 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541670}(cherry picked from commit 6243dfe00dab338151a161e582dbf75d72026a40) Reviewed-on: https://chromium-review.googlesource.com/958981 Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#158} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/708e98d990abcad327d048240e5eb12f0a03922d/chrome/browser/chrome_content_browser_client.cc
,
Mar 12 2018
,
Mar 12 2018
,
Mar 16 2018
Verified on build 66.0.3359.30 and 66.0.3370.0, looks good. The dialog is suppressed. We will add a new testcase when the dialog updated. |
|||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||
Comment 1 by cjgrant@chromium.org
, Mar 5 2018Labels: M-66 Pri-1
Status: Available (was: Untriaged)