New issue
Advanced search Search tips

Issue 817380 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

DCHECK failure in code->kind() == wasm::WasmCode::kFunction || code->kind() == wasm::WasmCode::kWa

Project Member Reported by ClusterFuzz, Feb 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5382082893971456

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  code->kind() == wasm::WasmCode::kFunction || code->kind() == wasm::WasmCode::kWa
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=51199:51200

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5382082893971456

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 28 2018

Labels: Test-Predator-Auto-Owner
Owner: clemensh@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/a2afcc1c096a66bb2ae6ca6915d318a816b2d77d ([wasm] Fix failures in --no-wasm-jit-to-native mode).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Labels: Pri-2
Status: Started (was: Assigned)

Comment 3 by kenrb@chromium.org, Mar 1 2018

Cc: kenrb@chromium.org
Labels: -Pri-2 Security_Impact-Head Pri-1
Cluster-fuzz labeled this a high severity security bug, which makes it a P1. If you think that assessment is wrong we can change it.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 1 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug-Security -Pri-1 -Restrict-View-SecurityTeam -Security_Impact-Head -Security_Severity-High -ReleaseBlock-Stable Security_Impact-None Pri-2 Type-Bug
This requires the --wasm-lazy-compilation flag, which is disabled by default. Hence no security implications and not a release blocker.

Comment 6 by kenrb@chromium.org, Mar 1 2018

Labels: -Type-Bug M-67 Security_Severity-High Restrict-View-SecurityTeam Type-Bug-Security
Thanks for the information. For vulnerabilities that are behind default-disabled flags we still track them as security bugs but with Impact set to None. In some cases that might be overly cautious but sometimes Chromium embedders often have different default flag configurations and can be affected.
Thanks for the explanation!
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6195ebe1608a8811218a34d0cd8cc67a454c3b43

commit 6195ebe1608a8811218a34d0cd8cc67a454c3b43
Author: Clemens Hammacher <clemensh@chromium.org>
Date: Fri Mar 02 09:48:11 2018

[wasm] Fix DCHECK for lazy compilation

Table inits can contain imported functions, hence their code will be a
wasm-to-wasm wrapper.
Fix a DCHECK and add a regression test.

R=ahaas@chromium.org

Bug:  chromium:817380 
Change-Id: I836be589e1ae66839ccd470154c8dea488e6bc1f
Reviewed-on: https://chromium-review.googlesource.com/943107
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51685}
[modify] https://crrev.com/6195ebe1608a8811218a34d0cd8cc67a454c3b43/src/wasm/module-compiler.cc
[add] https://crrev.com/6195ebe1608a8811218a34d0cd8cc67a454c3b43/test/mjsunit/regress/wasm/regress-817380.js

Status: Fixed (was: Started)
Thanks for the fast turnaround on the fix!
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 2 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by ClusterFuzz, Mar 3 2018

ClusterFuzz has detected this issue as fixed in range 51684:51685.

Detailed report: https://clusterfuzz.com/testcase?key=5382082893971456

Fuzzer: ochang_js_fuzzer
Job Type: linux_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  code->kind() == wasm::WasmCode::kFunction || code->kind() == wasm::WasmCode::kWa
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=51199:51200
Fixed: https://clusterfuzz.com/revisions?job=linux_d8_dbg&range=51684:51685

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5382082893971456

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Mar 3 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5382082893971456 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 8 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment