New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817376 link

Starred by 1 user
Status: Fixed
Owner:
eladalon@chromium.org
Closed: Feb 2018
Cc:
guidou@chromium.org
█ sindhu.chelamcherla@chromium.org
terelius@chromium.org
█ emadomara@chromium.org
webrtc-network-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK can be triggered in WebRTCInternals by dismissing dialog

Project Member Reported by eladalon@chromium.org, Feb 28 2018 
1. Navigate to chrome://webrtc-internals.
2. Click "Enable diagnostic packet and event recording"
3. Dismiss the dialog.
4. Click again.
5. Voilà!
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/910bcf05cbcbf53473c94979ce6a16b381dcbbb8

commit 910bcf05cbcbf53473c94979ce6a16b381dcbbb8
Author: Elad Alon <eladalon@chromium.org>
Date: Wed Feb 28 17:46:41 2018

Releae WebRTCInternals::select_file_dialog_ when dialog dismissed

Before this fix, the DCHECK on line 370 was hit.

Bug:  817376 
Change-Id: Ifd97fcb29e64f0ba3368521ae6e7bd37effc99c6
Reviewed-on: https://chromium-review.googlesource.com/941443
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539870}
[modify] https://crrev.com/910bcf05cbcbf53473c94979ce6a16b381dcbbb8/content/browser/webrtc/webrtc_internals.cc

Comment 2 by eladalon@chromium.org, Feb 28 2018

Status: Fixed (was: Assigned)

Comment 3 by eladalon@chromium.org, Feb 28 2018

Labels: M-66

Comment 4 by sindhu.chelamcherla@chromium.org, Mar 1 2018

Cc: sindhu.chelamcherla@chromium.org
Labels: Needs-Feedback
Unable to verify this issue as there are no errors in console either in build with fix or without fix. 

1. Navigated chrome://webrtc-internals , opened devtools
2. Clicked "Enable diagnostic packet and event recording" , cancelled it
3. Now again clicked on checkbox and didn't observe any error.

@eladalon: Could you please help us in verifying the fix. Please let us know how to and where to check the DCHECK triggering.

Thanks!
817376.ogv
3.4 MB View Download

Comment 5 by eladalon@chromium.org, Mar 1 2018 

DCHECKs are only active in debug builds. Did you try with a debug build?
►

Sign in to add a comment