Consider allowing ruleset verification to be done immediately |
||
Issue descriptionFlatbuffer verification is not cheap, so we hold off until we're absolutely sure we need to. For ad tagging, we probably don't want to block the first navigation on this. So we should probably just immediately verify the ruleset here [1], rather than blocking the navigation after the first response. Alternatively, could potentially implement this in a cleaner way via calling OnPageActivationComputed on nav start rather than when the response is received. [1]: https://cs.chromium.org/chromium/src/components/subresource_filter/content/browser/content_ruleset_service.cc?rcl=174f7bec8837d3ad39b945ba517ee9a69d4f5ee1&l=84
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa87929f95c1359bff2624894095b611adb8117e commit fa87929f95c1359bff2624894095b611adb8117e Author: Josh Karlin <jkarlin@chromium.org> Date: Fri Mar 09 16:19:41 2018 Verify the ruleset earlier on if AdsTagging is running Bug: 817365 Change-Id: I106d6b49c78f66b47a37d7f429b62b506ea5a225 Reviewed-on: https://chromium-review.googlesource.com/951823 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#542132} [modify] https://crrev.com/fa87929f95c1359bff2624894095b611adb8117e/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/fa87929f95c1359bff2624894095b611adb8117e/components/subresource_filter/content/browser/content_ruleset_service.cc
,
Mar 9 2018
,
Mar 23 2018
Great job Josh, it looks like this improved activation state computing delay by at the 99th %ile by a lot: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=6b977ffb79f6be85c23a9632f819e174 Almost 3x reduction.
,
Mar 23 2018
woot! |
||
►
Sign in to add a comment |
||
Comment 1 by jkarlin@chromium.org
, Feb 28 2018