New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817359 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Formalize the means by which the browser process uses SpeechRecognitionManager

Project Member Reported by cjgrant@chromium.org, Feb 28 2018

Issue description

VR uses a speech recognition session from within the browser process, but SpeechRecognitionManager was designed for use in render processes.  There is at least one other instance, on ChromeOS.

Recently, a DCHECK was added to ensure SpeechRecognitionSessionContext has a valid render_process_id.  This broke the browser-process cases, where kInvalidUniqueID was intentionally specified.

The breaking CL has been reverted.  The original was:

https://chromium-review.googlesource.com/c/chromium/src/+/922802

Before re-enabling the checks, we need to come up with a cleaner way to indicate "intentionally no render_process_id".
 

Comment 1 by a...@chromium.org, Feb 28 2018

Components: Blink>Speech
Labels: OS-Chrome
The ChromeOS uses it for accessibility from here: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/accessibility/dictation_chromeos.cc?l=42
Labels: -M-67 M-68
There is no imminent need to change anything here before M-67, so moving to M-68.
Owner: ----
Cc: bshe@chromium.org
Labels: -M-68 M-69

Comment 5 by samdrazin@chromium.org, Today (17 hours ago)

Labels: -M-69 VR-B-Input

Sign in to add a comment