New issue
Advanced search Search tips

Issue 817344 link

Starred by 1 user
Status: Assigned
Owner:
tzik@chromium.org
Cc:
gab@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

Support OnceCallback on base::OneShotTimer

Project Member Reported by tzik@chromium.org, Feb 28 2018 
base::Timer and its family currently don't support base::OnceCallback. And that is a blocker of the migration from legacy base::Callback to base::OnceCallback.
To support OnceCallback, IMO, we should split base::OneShotTimer to a separate class, update base::Timer usage to use OnceShotTimer or RepeatingTimer, and then, update the interface of base::OneShotTimer to use OnceCallback.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb99654e4a3b27213957733e19a609696b4b942

commit 7fb99654e4a3b27213957733e19a609696b4b942
Author: tzik <tzik@chromium.org>
Date: Thu Mar 01 11:39:20 2018

Remove BaseTimerMethodPointer

This CL moves RepeatingTimer and OneShotTimer to Timer by removing
BaseTimerMethodPointer, which is a middle level class.

Bug: 817344
Change-Id: I33ff580694a7359332ca4fcdc39b9d58c1d091b6
Reviewed-on: https://chromium-review.googlesource.com/940903
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540129}
[modify] https://crrev.com/7fb99654e4a3b27213957733e19a609696b4b942/base/timer/timer.h
►

Sign in to add a comment