New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817330 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651354
issue 694255



Sign in to add a comment

Posting tasks through v8 platform is slow

Project Member Reported by gab@chromium.org, Feb 28 2018

Issue description

I have anecdotal evidence that posting tasks through the v8 platform is slow (slower than the usual post task through TaskScheduler from Chromium that is).

Here's a proxy to infer this:

V8.GC.ParallelTaskLatencyMicroSeconds is always slower than TaskScheduler.TaskLatencyMicroseconds.Renderer.UserVisibleTaskPriority (which is a superset of V8.GC.ParallelTaskLatencyMicroSeconds).

https://uma.googleplex.com/histograms?endDate=20180226&dayCount=1&histograms=TaskScheduler.TaskLatencyMicroseconds.Renderer.UserVisibleTaskPriority%2CV8.GC.ParallelTaskLatencyMicroSeconds&fixupData=true&showMax=true&filters=platform%2Ceq%2CA%2Cchannel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

Appears to be true on all platforms.

I think this might contribute to the reason why we see the main thread sometimes being inactive for a while when kicking off parallel GC jobs (ref. ItemParallelJob). "idle" as in no trace events for a while until the main thread kicks off its task (I'm adding task_scheduler.flow tracing category to help highlight this for all PostTasks that land in TaskScheduler).

I'll try to save a trace next time I see this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3490fb77f34da6a9efa3edfc120cd9af4c2d494b

commit 3490fb77f34da6a9efa3edfc120cd9af4c2d494b
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Feb 28 15:02:19 2018

[gin] Do not create a new object on every background task posted from v8.

Bug:  817330 
Change-Id: Ifb402ed997f4c2b4d96e1b4124ee518b8700f69a
Reviewed-on: https://chromium-review.googlesource.com/940140
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539823}
[modify] https://crrev.com/3490fb77f34da6a9efa3edfc120cd9af4c2d494b/gin/v8_platform.cc

Comment 2 by gab@chromium.org, Feb 28 2018

Components: Internals>TaskScheduler

Comment 3 by gab@chromium.org, Apr 12 2018

Status: WontFix (was: Assigned)
This is not that bad actually in the wild, 1.20ms total on average over the first 30 seconds on startup : https://uma.googleplex.com/p/chrome/callstacks?sid=256e75a1a77133ecb2771f09a990d2a9

Sign in to add a comment