Regression: 'Microphone' and 'Camera' dropdowns are not properly aligned to one another.
Reported by
aiman.an...@etouch.net,
Feb 28 2018
|
||
Issue descriptionChrome Version: 66.0.3357.0 (Official Build) Revision 837639b937d3d1a084c246258ad1f460e4f0f68e-refs/heads/master@{#539659}(32/64 Bit) OS: Win(10), Linux(14.04 LTS), Mac(10.12.6,10.13.4) (Laptop Devices). Test URL: https://hangouts.google.com/webchat/start What steps will reproduce the problem? 1. Launch chrome, navigate to above URL, Sign-In and Select Video Call. 2. Allow Permission and click on microphone icon in Omnibox. 3. Observe Microphone bubble. Actual: 'Microphone' and 'Camera' dropdowns are not properly aligned to one another. Expected: 'Microphone' and 'Camera' dropdowns should be properly aligned to each another. This is a regression issue, broken in M-66 series, Using the per-revision bisect providing the bisect results, Good Build:66.0.3350.0(Revision:537343) Bad Build:66.0.3352.0(Revision:538313) You are probably looking for a change made after 537395 (known good), but no later than 537396 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/843d1d5f482db2974eba3a2ed016d835064974b0..e983a4e5bb74dda566a30dc325a4380b56cbd8b7 Suspect: https://chromium.googlesource.com/chromium/src/+/e983a4e5bb74dda566a30dc325a4380b56cbd8b7 bsep@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is only reproducible for Laptop Devices. 2. Issue is not reproducible for Desktop Devices (ie Win 7,8, 8.1 and Mac-Mini 10.13.1). Thank You!
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3bce1884445c557656386eeaab81dfa6c8d43df commit b3bce1884445c557656386eeaab81dfa6c8d43df Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Mar 22 22:38:38 2018 Fix microphone and camera comboboxes not aligned on the settings bubble. When I previously refactored ContentSettingBubbleContents I put the microphone and camera comboboxes on independent rows. However, if both are present it looks weird for the two comboboxes not to be aligned, so I've combined them into one dependent block to fix that. Bug: 817326 Change-Id: I5a43c502067db62b5a0e83b370ce43ddf00de03d Reviewed-on: https://chromium-review.googlesource.com/974566 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#545273} [modify] https://crrev.com/b3bce1884445c557656386eeaab81dfa6c8d43df/chrome/browser/ui/views/content_setting_bubble_contents.cc [modify] https://crrev.com/b3bce1884445c557656386eeaab81dfa6c8d43df/chrome/browser/ui/views/location_bar/content_setting_bubble_dialog_browsertest.cc
,
Mar 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bsep@chromium.org
, Mar 15 2018Status: Started (was: Assigned)