Check for locked fullscreen permission on non-CrOS platforms |
||||
Issue description
Currently the check is done only on ChromeOS, so the behaviour is a bit weird on eg. Windows Chrome where if you request a chrome.windows.create({state: 'locked-fullscreen'}) you will get a fullscreen window instead of a locked-fullscreen (and no errors), which is a bit confusing. Make it also error out on non-CrOS platforms.
So the locked-fullscreen functionality is available only on CrOS, and on other platforms it silently degenerates into regular fullscreen behaviour (which is probably mildly confusing to users).
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89d107ff8326d5bf36df6bc99a7112c1dc219cf8 commit 89d107ff8326d5bf36df6bc99a7112c1dc219cf8 Author: Ivan Sandrk <isandrk@google.com> Date: Fri Mar 02 08:29:56 2018 Enable locked fullscreen permission check on non-CrOS platforms The locked-fullscreen functionality is available only on CrOS, but on other platforms it silently degenerates into regular fullscreen behaviour which is probably mildly confusing to users. Make the behaviour consistent across platforms, so also error out on non-CrOS platforms (same as CrOS behaviour). Bug: chromium:817322 Change-Id: Idcbb80beeae896f981321264334dce30d8d3c845 Reviewed-on: https://chromium-review.googlesource.com/941125 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#540473} [modify] https://crrev.com/89d107ff8326d5bf36df6bc99a7112c1dc219cf8/chrome/browser/extensions/api/tabs/tabs_api.cc
,
Mar 15 2018
,
Apr 2 2018
,
Apr 2 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by minz@google.com
, Mar 1 2018