The AEC3 API call skew detector is too aggressive on platforms with high jitter in the API call sequence |
||||||
Issue descriptionOn platforms where there is a very high jitter in the API call sequence the AEC3 detector for shifts in the skew of the API calls may give a false alarm. The result can be a short echo leakage and/or lower transparency.
,
Mar 13 2018
,
Mar 13 2018
Has this been verified in Canary?
,
Mar 13 2018
Yes, this has been running in Canary for more than 10 days as part of the AEC3 experiment and the stats look good.
,
Mar 14 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/f68368feacf2bc08b9299b1300c478c0f394e96d commit f68368feacf2bc08b9299b1300c478c0f394e96d Author: Per Åhgren <peah@webrtc.org> Date: Thu Mar 15 12:25:17 2018 Merge to M66: Add a hysteresis for the API call skew detection to ... (cherry picked from commit 8447e91429708d32f11ec56a919c59d90ba0b031) TBR: gustaf@webrtc.org,henrik.lundin@webrtc.org Bug: webrtc:8954 , chromium:817313 Change-Id: I940d52ac96e5bddf886d47be089a1991ae24b51b Reviewed-on: https://webrtc-review.googlesource.com/58640 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#22228} Reviewed-on: https://webrtc-review.googlesource.com/62040 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/66@{#6} Cr-Branched-From: 12c8110e8c717b7f0f87615d3b99caac2a69fa6c-refs/heads/master@{#22215} [modify] https://crrev.com/f68368feacf2bc08b9299b1300c478c0f394e96d/api/audio/echo_canceller3_config.h [modify] https://crrev.com/f68368feacf2bc08b9299b1300c478c0f394e96d/modules/audio_processing/aec3/render_delay_controller.cc
,
Mar 15 2018
,
Mar 19 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
This was merged to M66 already, as per c#6. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Feb 28 2018