New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817285 link

Starred by 1 user
Status: Fixed
Owner:
weili@chromium.org
Closed: Mar 2018
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Thumbnails disappears on NTP after cancelling print

Reported by khushal....@etouch.net, Feb 28 2018 
Chrome Version: 66.0.3357.0 (Official Build) Revision: 837639b937d3d1a084c246258ad1f460e4f0f68e-refs/heads/master@{#539659} (32/64-bit)

OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.4), Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to NTP and give print command.
(2) Cancel print and observe thumbnails.

Actual: Thumbnails disappears on NTP after cancelling print.

Expected: Thumbnails should appear on NTP.

This is a regression issue, broken in 'M66' and will soon update bisect info.

Manual bisect:
Good Build: 66.0.3352.0
Bad Build:  66.0.3353.0
Actual_Video.mp4
462 KB View Download

Comment 1 by khushal....@etouch.net, Feb 28 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: weili@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 538652 (known good), but no later than 538653 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/2181305023501418e22e421c3ad7a2ecb0322b4d..00b5593b50a10f363c9128f25f0499e1ce1f3bf1

Suspect: https://chromium.googlesource.com/chromium/src/+/00b5593b50a10f363c9128f25f0499e1ce1f3bf1

@weili: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Expected_Video.mp4
381 KB View Download

Comment 2 by rbasuvula@chromium.org, Feb 28 2018

Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 3 by weili@chromium.org, Feb 28 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c1dd7ac3f592b3d913964104ca60c5a12ec4d2

commit 25c1dd7ac3f592b3d913964104ca60c5a12ec4d2
Author: Wei Li <weili@chromium.org>
Date: Thu Mar 01 06:43:04 2018

Restore local subframe size after printing

During refactoring of SetPrinting() in LocalFrame, for local subframes,
we accidentally forgot to call EndPrinting to restore its size. Fix it
and set correct expectation for unit test.

BUG= 817285 

Change-Id: I5187f9646cc9ed13a21f7093b33e2afa3bed88a4
Reviewed-on: https://chromium-review.googlesource.com/941885
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540073}
[modify] https://crrev.com/25c1dd7ac3f592b3d913964104ca60c5a12ec4d2/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/25c1dd7ac3f592b3d913964104ca60c5a12ec4d2/third_party/WebKit/Source/core/page/PrintContextTest.cpp

Comment 5 by weili@chromium.org, Mar 2 2018

Status: Fixed (was: Started)
Verified on Canary
Project Member

Comment 6 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Mar 2 2018

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-66; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-66 label, otherwise remove Merge-TBD label. Thanks.

Comment 7 by gov...@chromium.org, Mar 3 2018

Labels: -Merge-TBD
Cl listed at #4 is already in M66 branch (3359).
►

Sign in to add a comment