Issue metadata
Sign in to add a comment
|
Regression: Zoom-in/Zoom-out percentage does not change when zooming using ctrl+mouse-wheel.
Reported by
aiman.an...@etouch.net,
Feb 28 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3325.106 (Official Build) Revision 342c4a432d6ccd473ef0c1282e6adff217a4f61a-refs/branch-heads/3325@{#616} (32/64 Bit) OS: Win(7,8,8.1,10), Linux(14.04 LTS). Test URL:http://cb.vu/unixtoolbox.pdf What steps will reproduce the problem? 1. Launch chrome, navigate to above URL and zoom-in/zoom-out using Ctrl+Mouse-Wheel. 2. Observe. Actual: Zoom-in/Zoom-out percentage does not change when zooming using ctrl+mouse-wheel. Expected: Zoom-in/Zoom-out percentage should change when zooming. This is a regression issue, broken in M-64 series, Using the per-revision bisect providing the bisect results, Good Build:64.0.3267.0(Revision:515868) Bad Build:64.0.3268.0(Revision:516147) You are probably looking for a change made after 516033 (known good), but no later than 516034 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/a0ff710d32386aeeaa3587bd985a948b0a357c2b..bc61eb6a67219aa4352a4767d62d5b46719ca03e Suspect: https://chromium.googlesource.com/chromium/src/+/bc61eb6a67219aa4352a4767d62d5b46719ca03e mcnee@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is also reproducible on Stable #64.0.3282.168, Dev #66.0.3350.0 and Canary #66.0.3357.0 build. 2. Issue is not reproducible on Mac (10.12.6, 10.13.1, 10.13.4) OS Thank You!
,
Feb 28 2018
I can repro this. My change involves having ctrl-wheel zoom be extension-initiated rather than browser-initiated. Note that while the percentage does not change while the bubble is open, closing and reopening the bubble will cause it to display the correct percentage. Presumably, an open zoom bubble is not being refreshed in response to an extension-initiated zoom.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/741158fe9991a5af722f4ee7d7f20a1899ae2e71 commit 741158fe9991a5af722f4ee7d7f20a1899ae2e71 Author: Kevin McNee <mcnee@chromium.org> Date: Thu Jun 28 14:56:55 2018 Refresh zoom bubble if visible following whitelisted extension zoom. Extensions may be whitelisted to suppress the zoom bubble when performing an extension initiated zoom (e.g. the PDF viewer). However, this also suppressed updates to the zoom bubble if it was already being shown. We now update the zoom bubble (if it exists) in this case. Bug: 817278 Change-Id: Ia746f25de2760e8349a1ec3d3f4c899392d0fc81 Reviewed-on: https://chromium-review.googlesource.com/1086153 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#571124} [modify] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc [modify] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/chrome/browser/ui/views/location_bar/zoom_bubble_view.h [modify] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc [modify] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/extensions/browser/extension_zoom_request_client.h
,
Jun 29 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aiman.an...@etouch.net
, Feb 28 2018