ShapeResult::num_characters is -1 when small-caps is used |
|||||
Issue descriptionThe CL https://chromium-review.googlesource.com/c/chromium/src/+/939942 kicked this condition in fast/inline/absolute-positioned-inline-in-centred-block.html https://test-results.appspot.com/data/layout_results/linux_chromium_rel_ng/35457/site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
,
Feb 28 2018
Test: https://chromium-review.googlesource.com/c/chromium/src/+/940783
,
Feb 28 2018
Thanks for spotting that, please assign it to me if you would like me to take a look? Or are you going to investigate yourself? Perhaps something wrong in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.h?q=HarfBuzzBufferFiller&sq=package:chromium&dr=CSs&l=5
,
Feb 28 2018
Great if you can take a look, thank you! Note, this may not repro on Windows due to different kerning.
,
Mar 13 2018
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f84e158253c2f39665f848d124460f20aca1179 commit 1f84e158253c2f39665f848d124460f20aca1179 Author: Dominik Röttsches <drott@chromium.org> Date: Thu Mar 15 19:02:56 2018 Fix subrange shaping logic when small caps feature is active The existing logic was to exclude segmenter output that does not overlap with range start and range end (HarfBuzzShaper::Shape) and to restrict shaping to the character indexes of the queue items that contribute to the desired range. However, the latter restriction only worked if the case mapping for small caps did not chop up the queue items further, due to case change segmentation. Adding an early-out if the result of case mapping chopping produces queue items that fall outside the desired range. Thanks to kojii@ for the report and initial test case. Bug: 817271 Test: RangeShapeSmallCaps Change-Id: If8c0b00343e7b1c9a342305e5f44fa515ba3576c Reviewed-on: https://chromium-review.googlesource.com/964445 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#543464} [modify] https://crrev.com/1f84e158253c2f39665f848d124460f20aca1179/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp [modify] https://crrev.com/1f84e158253c2f39665f848d124460f20aca1179/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
,
Mar 15 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kojii@chromium.org
, Feb 28 2018