New issue
Advanced search Search tips

Issue 817258 link

Starred by 1 user
Status: Fixed
Owner:
rmcilroy@chromium.org
Closed: Mar 2018
Cc:
mythria@chromium.org
rmcilroy@chromium.org
toyoshim@chromium.org
mstarzinger@chromium.org
marja@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.1% regression in system_health.memory_desktop at 538326:538426

Project Member Reported by toyoshim@chromium.org, Feb 28 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Feb 28 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=817258

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9505793f32eb98484ca612f7f3e26ffd4ac31f17c3e969c54cf1df5664409d3f


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-air
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 28 2018

Cc: mstarzinger@chromium.org mythria@chromium.org rmcilroy@chromium.org marja@chromium.org
Owner: rmcilroy@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/148b7a38440000

[Compiler] Move BackgroundParsingTask to compiler.cc by rmcilroy@chromium.org
https://chromium.googlesource.com/v8/v8/+/d2a370494e737c4ec2b99ca8d7dbe97b4e87d861

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9a97d9756dac6ebf9f4b33ba64278cfd8d0dfde8

commit 9a97d9756dac6ebf9f4b33ba64278cfd8d0dfde8
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Mon Mar 05 16:21:31 2018

[Compiler] Remove script_data from BackgroundCompileTask.

This field is dead since https://chromium-review.googlesource.com/c/v8/v8/+/916261, but got
accidentally added back by https://chromium-review.googlesource.com/c/v8/v8/+/919481 due to
a bad merge.

BUG= v8:5203 , chromium:817258 

Change-Id: Id6f06de84de7dcd4e6d467edf28974912ad33571
Reviewed-on: https://chromium-review.googlesource.com/948849
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51738}
[modify] https://crrev.com/9a97d9756dac6ebf9f4b33ba64278cfd8d0dfde8/src/compiler.cc

Comment 5 by rmcilroy@chromium.org, Mar 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment