ArcAppWindow should cast View to ShellSurfaceBase. |
||
Issue descriptionArcAppWindow casts View to ShellSurface. However for ARC++ it's actually ClientControlledShellSurface. To make it generic, we should cast View to ShellSurfaceBase which is a shared base class of ShellSurface and ClientControlledShellSurface. https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/arc_app_window.cc?rcl=346fd738febe7358c7383db85c570199a824bd1c&l=167
,
Mar 2 2018
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95e9975e27c78a128c16e1950374fa73a91cd731 commit 95e9975e27c78a128c16e1950374fa73a91cd731 Author: Daichi Hirono <hirono@chromium.org> Date: Fri Mar 02 01:50:43 2018 ArcAppWindow should cast View to ShellSurfaceBase. Previously ArcAppWindow casts View to ShellSurface. However for ARC++ it's actually ClientControlledShellSurface. To make it generic, the change casts View to ShellSurfaceBase which is a shared base class of ShellSurface and ClientControlledShellSurface. Bug: 817244 Test: Manually tested on kevin Change-Id: I26604522a6e28999032bd7a1bc1a3466f797cbec Reviewed-on: https://chromium-review.googlesource.com/939884 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#540408} [modify] https://crrev.com/95e9975e27c78a128c16e1950374fa73a91cd731/chrome/browser/ui/ash/launcher/arc_app_window.cc |
||
►
Sign in to add a comment |
||
Comment 1 by hirono@chromium.org
, Mar 2 2018