New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817238 link

Starred by 5 users
Status: Fixed
Owner:
█ fsam...@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
█ fsam...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
paulir...@chromium.org
ccameron@chromium.org
dgozman@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Google chrome logo image appears chopped in emulated view of devtools.

Reported by rp...@etouch.net, Feb 28 2018 
Version: 66.0.3356.0 (Official Build) Revision43318c02bb32c8eb07e9739904d15778d64d3094-refs/heads/master@{#539380}(64-bit)
OS: Mac OS X(10.12.6,10.13.1)

URL : chrome://theme/IDR_PRODUCT_LOGO

What steps will reproduce the problem?
1. Launch chrome,navigate to above url and open devtools
2. Now open emulated view and drag devtools window to LHS,observe
 
Actual: Google chrome logo image appears chopped in emulated view of devtools
Expected: Google chrome logo image should be seen properly in emulated view of devtools

This is regression issue, broken in ‘M 66’ and below is the bisect info :
Good build: 66.0.3350.0  (Revision: 537343).
Bad build: 66.0.3352.0 (Revision: 538313).

You are probably looking for a change made after 538041 (known good), but no later than 538042 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b82cc83c724a875f27ff7986cb3037e9231e8999..e24c90e284ccaae925132cc0271d9179b5560ec3

Suspect : https://chromium.googlesource.com/chromium/src/+/e24c90e284ccaae925132cc0271d9179b5560ec3

From the CL above, assigning the issue to the concern owner 

@fsamuel- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : This issue is not seen on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac Touch bar OS X(10.13.4) OS

Thanks!
Actual_video.mov
2.4 MB View Download
Expected_video.mov
1.8 MB View Download

Comment 1 by fsam...@chromium.org, Feb 28 2018

Cc: ccameron@chromium.org
+ccameron@

Comment 2 by fsam...@chromium.org, Feb 28 2018 

I'm running into this issue on Linux too if I provide the flag --enable-use-zoom-for-dsf=false.

Also if I turn device emulation on and off a couple of times, I get surface invariants violations:

Surface invariants violation: [OOPIF? 0] RenderWidgetSurfaceProperties(device_scale_factor(this: 1, other: 3))

Investigating now.

Comment 3 by fsam...@chromium.org, Feb 28 2018 

#3 0x7f834dd3c83c cc::LayerTreeHost::SetViewportSizeAndScale()
#4 0x7f835145edde content::RenderWidgetCompositor::SetViewportSizeAndScale()
#5 0x7f835169e4fa content::RenderWidget::UpdateCompositorSurface()
#6 0x7f83516a56cd content::RenderWidget::Resize()
#7 0x7f83513e13b8 content::RenderWidgetScreenMetricsEmulator::Apply()
#8 0x7f83516a02d4 content::RenderWidget::OnEnableDeviceEmulation()

The surface invariants violation happens as soon as we turn on device emulation. Continuing to investigate.

Comment 4 by fsam...@chromium.org, Feb 28 2018

Cc: dgozman@chromium.org paulir...@chromium.org fsam...@chromium.org
 Issue 817081  has been merged into this issue.

Comment 5 by rp...@etouch.net, Mar 1 2018

Labels: RegressedIn-66 FoundIn-66 Target-66

Comment 6 by fsam...@chromium.org, Mar 1 2018

Status: Fixed (was: Assigned)
This should be fixed as of this CL:

https://chromium-review.googlesource.com/c/chromium/src/+/938958

Comment 7 by paulir...@chromium.org, Mar 1 2018 

thanks ccameron and fady. appreciate it.

Comment 8 by paulir...@chromium.org, Mar 8 2018 

For reference, the regression made it to m65.
It was discovered and filed as  issue 819489 . 

A hotfix was applied to m65 so we're good as of 65.0.3325.150. (and m66 is still in good shape, as well.)
►

Sign in to add a comment