Issue metadata
Sign in to add a comment
|
77.2% regression in thread_times.key_silk_cases at 539291:539358 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 28 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ae1ce8440000
,
Mar 1 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14ae1ce8440000 Revert "Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)"" by robertphillips@google.com https://skia.googlesource.com/skia/+/934c3d0c548d254a0d986963ee751caf0ffcb500 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 16 2018
This recovered.
,
Mar 19 2018
https://skia-review.googlesource.com/c/skia/+/110221 (Revert "Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)") relanded: https://skia-review.googlesource.com/c/skia/+/109749 (Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)) which had an unfortunate texture over-allocation bug. It was reverted in: https://skia-review.googlesource.com/c/skia/+/111080 (Revert "Revert "Revert "Separate creation time & flush time behavior in GrDrawOpAtlas (take 2)""") which corresponds to the perf recovery on the Chrome bots. This bug was fixed (and the CL relanded in) in: https://skia-review.googlesource.com/c/skia/+/111100 (Separate creation time & flush time behavior in GrDrawOpAtlas (take 3)) This CL rolled into Chrome on 3/5/18 at r540824 and displayed no perf regressions. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Feb 28 2018