Add a histogram to count voice search calls from: 1) NTP 2) Omnibox 3) Search widget I'd like to know the proportion that's coming from each source. Today we don't record any metrics for NTP/search widget code path.
Do we want to modify this to record new metrics for if the voice search actually completes? We're only recording if the button is pressed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde commit b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde Author: Troy Hildebrandt <thildebr@chromium.org> Date: Mon Apr 02 23:30:36 2018 Adds metrics recording for the source of voice interactions. Right now we only record a metric on when a voice search is triggered in the omnibox, and nowhere else. This patch records where the start of a voice interaction comes from, and if completed successfully resulting in either suggestions or a navigation to a SRP, the source of the finish event as well. This currently includes omnibox, NTP, and the search widget. This also includes a minor refactoring, pulling voice search logic out LocationBarLayout and into its own class, LocationBarVoiceRecognitionHandler. Bug: 817228 Change-Id: Ie0a97ecbbec92c9189e4454e67c94b18ca4c7ffe Reviewed-on: https://chromium-review.googlesource.com/943598 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547560} [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java [add] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandler.java [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/java_sources.gni [add] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandlerTest.java [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b6d6ad8b100ff8965e9fbcc9447ba84c05ba3cde/tools/metrics/histograms/histograms.xml
Comment 1 by thildebr@chromium.org
, Feb 28 2018