New issue
Advanced search Search tips

Issue 817224 link

Starred by 3 users
Status: Assigned
Owner:
vasi...@chromium.org
Cc:
maxwalker@chromium.org
nyerramilli@chromium.org
kolos@chromium.org
rbasuvula@chromium.org
vasi...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Regression:Flickering of password bubble is seen after hitting 'Esc' key to close Re-authentication with OS password prompt.

Reported by vku...@etouch.net, Feb 28 2018 
Chrome Version: 66.0.3356.0 (Official Build) 43318c02bb32c8eb07e9739904d15778d64d3094-refs/heads/master@{#539380}(64 bit) 
OS: Mac(10.12.6, 10.13.1, 10.13.4)

What steps will reproduce the problem?
(1)Launch chrome and login to https://twitter.com/ with valid credentials.
(2)Press cmd+l and tab key such that focus appears on key icon, hit enter to open overlay.
(3)Press tab key such that focus reaches on eye icon, hit spacebar key such that Re-authentication with OS password prompt appears.
(4)Now press 'Esc' key and observe the password bubble.

Actual: Flickering of password bubble is seen after hitting 'Esc' key to close Re-authentication with OS password prompt.

Expected: No such flickering of password bubble should be seen after hitting 'Esc' key to close Re-authentication with OS password prompt.

This is a regression issue broken in 'M66' and below is the manual bisect info
Good build: 66.0.3328.0 (Revision:530802)
Bad build:  66.0.3329.0 (Revision:531127)

Note: Issue not seen on Windows(7,8,8.1,10) & Linux (14.04 LTS)
Actual_Password.mov
4.5 MB View Download
Expected_Password.mov
1.7 MB View Download

Comment 1 by vku...@etouch.net, Feb 28 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: vasi...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 530873 (known good), but no later than 530874 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/f7e99cf6fca9b86d824a168ab21a6c51cf1b854e..85b9d0662601895ecb6b25977ce3117725d0d525

Suspect: https://chromium.googlesource.com/chromium/src/+/85b9d0662601895ecb6b25977ce3117725d0d525 

@vasilii: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by vasi...@chromium.org, Feb 28 2018

Cc: maxwalker@chromium.org
Labels: -Pri-1 Pri-2
That's not feasible to fix. When the reauth popup appears then the bubble looses focus. It doesn't disappear immediately just because whole Chrome freezes. Once the pop up is gone we reopen the bubble. Obviously we want to bring the bubble back especially if the reauth was successful.
What I can do is to hide the bubble the moment user presses the eye icon. That happens on other platforms. Max, WDYT?

Comment 3 by maxwalker@chromium.org, Mar 14 2018 

>> What I can do is to hide the bubble the moment user presses the eye icon.

I think that wouldn't improve the behavior. Keeping the popover visible when the auth dialog is shown makes it easier to understand what triggered the dialog. So I'd suggest to keep the current behavior if we can't fix the root cause (popover not staying visible).

Comment 4 by vasi...@chromium.org, Mar 15 2018

Labels: -Pri-2 -Type-Bug-Regression -M-66 -RegressedIn-66 -Target-66 OS-Chrome OS-Linux OS-Windows Pri-3 Type-Bug
May be we could try to change it for all the platforms so that it stays visible. I don't think it's more than P3 at the moment.

Comment 5 by vasi...@chromium.org, May 14 2018

Cc: kolos@chromium.org vasi...@chromium.org
 Issue 819141  has been merged into this issue.
►

Sign in to add a comment