New issue
Advanced search Search tips

Issue 817186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 417782
issue 781428



Sign in to add a comment

[root layer scrolls] inspector-protocol/css/css-get-background-colors.js is failing

Project Member Reported by pdr@chromium.org, Feb 28 2018

Issue description

inspector-protocol/css/css-get-background-colors.js is failing with root layer scrolling:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=inspector-protocol%2Fcss%2Fcss-get-background-colors.js

This looks like a real failure where the returned background color is always ["rgb(255, 255, 255)"].
 

Comment 1 by pdr@chromium.org, Feb 28 2018

Owner: pdr@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af58743dbd695a1feec4cd13268dcc58214ed1bb

commit af58743dbd695a1feec4cd13268dcc58214ed1bb
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Mar 01 18:48:52 2018

[PE] Respect hit test clip behavior throughout PaintLayer::HitTestLayer

Hit tests can ignore clips and PaintLayer::HitTestLayer partially
honored this setting but did not pass it along when computing clip
rects for each layer fragment.

Bug:  817186 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icedf0470dfb06bb68f7f3c11a26a9a475262ac74
Reviewed-on: https://chromium-review.googlesource.com/942471
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540230}
[modify] https://crrev.com/af58743dbd695a1feec4cd13268dcc58214ed1bb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/af58743dbd695a1feec4cd13268dcc58214ed1bb/third_party/WebKit/LayoutTests/platform/mac-mac10.12/compositing/scroll-with-inner-clip-expected.png
[add] https://crrev.com/af58743dbd695a1feec4cd13268dcc58214ed1bb/third_party/WebKit/LayoutTests/platform/win/compositing/scroll-with-inner-clip-expected.png
[modify] https://crrev.com/af58743dbd695a1feec4cd13268dcc58214ed1bb/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/af58743dbd695a1feec4cd13268dcc58214ed1bb/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp

Comment 3 by pdr@chromium.org, Mar 1 2018

Status: Fixed (was: Assigned)

Sign in to add a comment