Highlighted extension icon looks bad |
||
Issue descriptionChrome Version : 66.0.3346.8 OS Version: 10.0 When an extension icon is used to anchor a message, it doesn't match other anchors in Harmony. Attached image, as well as comparison with star highlight. (1) The color is wrong (2) There's an outline (3) The shape is too large horizontally (should be square and centered on the icon) (4) The anchored dialog should be horizontally aligned with the edge of the highlight +CC abdulsyed to put this one whatever relevant lists there are.
,
Mar 6 2018
Way better! Seems like the bubble should be left 2 px and up at least 1.
,
Mar 6 2018
I did nothing to adjust the location of the bubble. That can/should be a separate issue if the related CL: https://chromium-review.googlesource.com/c/chromium/src/+/952087 is taken.
,
Mar 6 2018
Comment 0 item (4) talks about the popup alignment :) (I didn't mention the vertical there though) To be clear though, the screenshot in comment 2 is way more shippable and this would become more like P3 for me.
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/848ef69a5ef32d54882d9716193a4c1d467749a2 commit 848ef69a5ef32d54882d9716193a4c1d467749a2 Author: Allen Bauer <kylixrd@chromium.org> Date: Thu Mar 08 23:45:29 2018 Don't use the odd yellow-ish highlight rect around the whole BrowserActionsContainer. Instead, highlight each button as needed. TBR=oshima@chromium.org Bug: 817180 Change-Id: I9005dd611534b69127dbbcfec666ffb2a81da27d Reviewed-on: https://chromium-review.googlesource.com/952087 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541939} [modify] https://crrev.com/848ef69a5ef32d54882d9716193a4c1d467749a2/chrome/app/theme/theme_resources.grd [modify] https://crrev.com/848ef69a5ef32d54882d9716193a4c1d467749a2/chrome/browser/ui/views/toolbar/browser_actions_container.cc [modify] https://crrev.com/848ef69a5ef32d54882d9716193a4c1d467749a2/chrome/browser/ui/views/toolbar/browser_actions_container.h [modify] https://crrev.com/848ef69a5ef32d54882d9716193a4c1d467749a2/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
,
Mar 12 2018
Tested the issue on Windows-10, Debian rodete and Mac OS 10.13.3 using chrome latest Canary M67-67.0.3368.0 and chrome OS on #67.0.3366.3 by following steps mentioned in the original comment. Observed that 1. Colour displaying as per start highlight. 2. Outline is displaying properly. 3. Bubble displaying properly. @pkasting: Could you please find the screen shot of the issue and confirm the expected behaviour of the issue. Thank you! |
||
►
Sign in to add a comment |
||
Comment 1 by kylixrd@chromium.org
, Mar 6 2018Status: Assigned (was: Untriaged)