New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817175 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in __msan_memcpy

Project Member Reported by ClusterFuzz, Feb 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5807055143960576

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000098
Crash State:
  __msan_memcpy
  cc::draw_property_utils::ComputeClips
  cc::LayerTreeHost::DoUpdateLayers
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=518240:518474

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5807055143960576

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Feb 28 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: brajkumar@chromium.org
Labels: M-65 Test-Predator-Wrong CF-NeedsTriage
Unable to find actual suspect through code search and also from the provided CL under regression range, hence adding appropriate label and leaving it as untriaged for further updates.

Thanks!

Comment 3 by piman@chromium.org, Mar 2 2018

Owner: weiliangc@chromium.org
Status: Assigned (was: Untriaged)
Looks like parent_clip_node is null. Property tree issues? ->weiliangc if she has an idea

Comment 4 by piman@chromium.org, Mar 2 2018

Cc: sunn...@chromium.org trchen@chromium.org
 Issue 817019  has been merged into this issue.

Comment 5 by piman@chromium.org, Mar 2 2018

Cc: -trchen@chromium.org weiliangc@chromium.org
Owner: trchen@chromium.org
duped bug suggests 
[Blink] Fixing a series of composited clip bug by trchen@chromium.org - https://chromium.googlesource.com/chromium/src/+/09dd9e06d4c19f4702597e8563d9b956e4dac9ae might be at fault. ->trchen
Project Member

Comment 6 by ClusterFuzz, Mar 2 2018

Labels: OS-Windows

Comment 7 by trchen@chromium.org, Mar 12 2018

Cc: trchen@chromium.org
 Issue 820843  has been merged into this issue.
Project Member

Comment 8 by ClusterFuzz, Mar 12 2018

Labels: OS-Mac
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb

commit ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Mon Mar 12 21:32:02 2018

[Blink] Avoid O(n) lookup during clip parent computation

Similar to the previous alike-titled CL "[Blink] Avoid O(n) lookup during
scroll parent computation", this CL changes CompositingInputsUpdater to
keep track of clip chain information in recursion context for different
type of positioned descendants to achieve O(1) lookup.

And conveniently workaround  crbug.com/817175 

BUG= 818768 , 817175 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib8bb76eb219a7056d6488484cc8439d44e7d7aac
Reviewed-on: https://chromium-review.googlesource.com/956503
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542605}
[modify] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/third_party/WebKit/LayoutTests/compositing/overflow/clip-escaping-reverse-order-should-not-crash-expected.html
[add] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/third_party/WebKit/LayoutTests/compositing/overflow/clip-escaping-reverse-order-should-not-crash.html
[modify] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdater.cpp
[modify] https://crrev.com/ffc26d979f5e1b236278ab23f5f9e9c32a0ae9bb/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdater.h

Project Member

Comment 10 by ClusterFuzz, Mar 13 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5728937272147968 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by ClusterFuzz, Mar 13 2018

ClusterFuzz has detected this issue as fixed in range 542596:542607.

Detailed report: https://clusterfuzz.com/testcase?key=5807055143960576

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000098
Crash State:
  __msan_memcpy
  cc::draw_property_utils::ComputeClips
  cc::LayerTreeHost::DoUpdateLayers
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=518240:518474
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=542596:542607

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5807055143960576

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment