New issue
Advanced search Search tips

Issue 817158 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 791806



Sign in to add a comment

New Download Manager UI is not displayed during swipe to switch tab gesture

Project Member Reported by eugene...@chromium.org, Feb 28 2018

Issue description

App Version (from "Chrome Settings > About Chrome"): ToT
iOS Version: All
Device: iPhone

Steps to reproduce: 
1.) Enable New Download Manager in chrome://flags
2.) Load https://www.barebones.com/products/bbedit/download.html
3.) Tap Download
4.) Open a new Tab
5.) Side swipe toolbar to switch to the previous tab

Observed behavior: 
Download Manager UI is not displayed during side swipe

Expected behavior: 
Download Manager UI should be a part of snapshot

 
Blocking: 791806
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0205d8ed30d0588edd6d22f9819797cc1d0839f2

commit 0205d8ed30d0588edd6d22f9819797cc1d0839f2
Author: Eugene But <eugenebut@google.com>
Date: Fri Mar 02 01:59:37 2018

Add Download Manager view to snapshotting overlays.

Overlays are used to make snapshots to Tab Switcher and for Side Swipe
Tab switching.

Bug:  817158 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I66c29e45b5693af77dff70aafa6476a5181c9642
Reviewed-on: https://chromium-review.googlesource.com/940627
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540411}
[modify] https://crrev.com/0205d8ed30d0588edd6d22f9819797cc1d0839f2/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/0205d8ed30d0588edd6d22f9819797cc1d0839f2/ios/chrome/browser/ui/download/download_manager_coordinator.h
[modify] https://crrev.com/0205d8ed30d0588edd6d22f9819797cc1d0839f2/ios/chrome/browser/ui/download/download_manager_coordinator.mm
[modify] https://crrev.com/0205d8ed30d0588edd6d22f9819797cc1d0839f2/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on iPhoneX iOS 11.2.6 ,iPhone 7+ iOS10.3.3 on build 67.0.3396.50 Beta

Sign in to add a comment