New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817148 link

Starred by 2 users
Status: Verified
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Apr 2018
Cc:
dougman@chromium.org
█ leilei@chromium.org
yfried...@chromium.org
sko...@chromium.org
█ gordonbrander@chromium.org
dbbrooks@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

Quota Management permission request doesn't show up in VR Browsing

Project Member Reported by vsupruniuk@google.com, Feb 28 2018 
Chrome Version: 66.0.3356.0
OS: Android

Reproduction steps:

1. Clear Chrome settings:
      Go to Android settings -> Apps -> Chrome -> Storage -> Manage space -> Clear All Data
2. Enable permissions for Chrome, go to:
      Go to Android settings -> apps -> Chrome -> Permissions:
	- enable Storage permission
	- enable Location permission
	- enable Camera permission
	- enable Microphone permission
3. Open Chrome, complete First Run Experience
4. Open chrome://flags and enable required flags:
	#vr-browsing-native-android-ui
	#vr-web-input-editing
   Relaunch Chrome
5. Access https://permission.site/ on the test device. 
6. Enter Chrome VR
7. Click “Quota Management” button


What is the expected result?
- Permission prompt appears in Chrome VR

What happens instead?
- Permission prompt is absent, button color remains unchanged

Comment 1 by cjgrant@chromium.org, Feb 28 2018

Components: UI>Browser>VR
Labels: -Restrict-View-Google -Pri-3 -Proj-VR-Shell Pri-2
Status: Available (was: Untriaged)
Elevating the priority on this one, as all permissions popups should now work.  We need to figure out why this particular one isn't showing.

Comment 2 by ericde@google.com, Mar 21 2018

Cc: sko...@chromium.org gordonbrander@chromium.org yfried...@chromium.org
Labels: -Pri-2 -M-66 M-67 Hotlist-VRB-MVP Pri-1
UI is turned on in M67 by default, so moving this to 67 and marking it as Hotlist-VRB-MVP.

Comment 3 by bshe@chromium.org, Apr 10 2018

Owner: bshe@chromium.org
Status: Started (was: Available)
seems like it is just a matter of enabling the UI while in VR. I will upload a CL soon.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1

commit 04bd7e4d3c495ce208b9a89a46567b609f5fa5c1
Author: Biao She <bshe@chromium.org>
Date: Thu Apr 12 15:12:17 2018

Enable quota management permission request UI in VR

This CL also did the following three things:
1. refactored the code for checking if we should suppress 2D UI.
2. add kOsStoragePermission enum to represent suppress native storage
UI request(currently only Android).
3. add kMediaRouterPresentationRequest enum to represent suppress media
router presentation.


Bug:  817148 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id8e0bdc961ffcbcd1f0bc7145be2998ca949602e
Reviewed-on: https://chromium-review.googlesource.com/1005842
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550204}
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/chrome_quota_permission_context.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/android/ssl_client_certificate_request.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/android/usb_chooser_dialog_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/vr/ui_suppressed_element.h
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/vr/vr_tab_helper.h
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/tools/metrics/histograms/enums.xml

Comment 5 by bshe@chromium.org, Apr 13 2018

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1

commit 04bd7e4d3c495ce208b9a89a46567b609f5fa5c1
Author: Biao She <bshe@chromium.org>
Date: Thu Apr 12 15:12:17 2018

Enable quota management permission request UI in VR

This CL also did the following three things:
1. refactored the code for checking if we should suppress 2D UI.
2. add kOsStoragePermission enum to represent suppress native storage
UI request(currently only Android).
3. add kMediaRouterPresentationRequest enum to represent suppress media
router presentation.


Bug:  817148 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id8e0bdc961ffcbcd1f0bc7145be2998ca949602e
Reviewed-on: https://chromium-review.googlesource.com/1005842
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550204}
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/chrome_quota_permission_context.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/android/ssl_client_certificate_request.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/android/usb_chooser_dialog_android.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/vr/ui_suppressed_element.h
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/chrome/browser/vr/vr_tab_helper.h
[modify] https://crrev.com/04bd7e4d3c495ce208b9a89a46567b609f5fa5c1/tools/metrics/histograms/enums.xml

Comment 7 by dougman@chromium.org, May 8 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified in build 67.0.3396.29 beta, looks good.
►

Sign in to add a comment