Make media capabilities "is smooth" dropped frames threshold configurable via field trial |
|||
Issue descriptionCurrently, when the ratio of frames dropped / decoded <= 10%, we classify the playback as "smooth". This conservative value was chosen after a few rounds of lab testing where I pushed different machines to their breaking point with high resolution / framerate content, and subjectively assessed what I could tolerate in terms of dropped frames. We plan to eventually run more subjective tests and may adjust the 10% threshold. Using a field trial allows this adjustment to take place outside of the chrome release cadence.
,
Feb 28 2018
> Is this usage generally agreeable? Yes. You probably want to use GetFieldTrialParamByFeatureAsDouble().
,
Feb 28 2018
Thanks! I was on the fence about that vs base::StringToDouble(GetFieldTrialParamValue(...)) the trade off being this one doesn't require a _feature_ to be defined... I don't technically have a feature associated with my double. Thoughts?
,
Feb 28 2018
We generally recommend people use features and trigger behavior off of features rather than use field trial names. It's more flexible. http://go/finch-feature-api
,
Nov 23
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde commit 8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Nov 27 23:51:51 2018 Media Capabilities: make the smooth threshold configurable via Finch. Bug: 817136 Change-Id: I225591b1c6fdcaf50475a1a81cc2f2d5445b9eb3 Reviewed-on: https://chromium-review.googlesource.com/c/1351908 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#611426} [modify] https://crrev.com/8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde/media/base/media_switches.cc [modify] https://crrev.com/8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde/media/base/media_switches.h [modify] https://crrev.com/8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde/media/mojo/services/video_decode_perf_history.cc [modify] https://crrev.com/8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde/media/mojo/services/video_decode_perf_history.h [modify] https://crrev.com/8d1cffce0a566b9d5f5ffedfb66185c9d31dcfde/media/mojo/services/video_decode_perf_history_unittest.cc
,
Nov 29
|
|||
►
Sign in to add a comment |
|||
Comment 1 by chcunningham@chromium.org
, Feb 28 2018Labels: -M-66 M-67