VR: Handle insecure login pop-ups while in VR |
||||||||
Issue descriptionWhat steps will reproduce the problem? (1) In VR, go to an insecure website that has a password field (2) Summon the keyboard by clicking on the field (3) Notice the 2D "Page not secure" popup show up while in VR Just like the autofill pop-ups, these should be disabled.
,
Mar 6 2018
moving to M67 where we will finish up the 2d UI work.
,
Mar 7 2018
This will need to into M66 otherwise users may see a 2D popup when editing web input.
,
Mar 7 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22dc6d728ca33d7172aef1c25e0419a11ace8f3a commit 22dc6d728ca33d7172aef1c25e0419a11ace8f3a Author: Yash Malik <ymalik@google.com> Date: Thu Mar 08 00:35:43 2018 VR: Disable all autofill popups when in VR mode. Bug: 817127 Change-Id: I30343146b3fe8f84cf04bf7fe68fd330fa12f48c Reviewed-on: https://chromium-review.googlesource.com/952194 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#541655} [modify] https://crrev.com/22dc6d728ca33d7172aef1c25e0419a11ace8f3a/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/22dc6d728ca33d7172aef1c25e0419a11ace8f3a/components/autofill/core/browser/autofill_manager.cc
,
Mar 8 2018
,
Mar 8 2018
Please verify in Canary
,
Mar 9 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 9 2018
Verified on Canary.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82bfc66efc00087074e8ce739195b5f95084624e commit 82bfc66efc00087074e8ce739195b5f95084624e Author: Yash Malik <ymalik@google.com> Date: Fri Mar 09 14:11:02 2018 VR: Disable all autofill popups when in VR mode. Bug: 817127 Change-Id: I30343146b3fe8f84cf04bf7fe68fd330fa12f48c Reviewed-on: https://chromium-review.googlesource.com/952194 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541655}(cherry picked from commit 22dc6d728ca33d7172aef1c25e0419a11ace8f3a) Reviewed-on: https://chromium-review.googlesource.com/955867 Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#132} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/82bfc66efc00087074e8ce739195b5f95084624e/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/82bfc66efc00087074e8ce739195b5f95084624e/components/autofill/core/browser/autofill_manager.cc
,
Mar 9 2018
,
Mar 12 2018
Verified in 66.0.3359.28 and 67.0.3368.0 the AutoFill popups are disabled. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ericde@google.com
, Mar 3 2018