New issue
Advanced search Search tips

Issue 817116 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: Mar 2018
Cc:
sadrul@chromium.org
afakhry@chromium.org
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add time_stamp to ui::Accelerator

Project Member Reported by wutao@chromium.org, Feb 27 2018 
We want to measure the latency between a key-pressing to the time of the  presentation of next UI frame.

sky@ implemented this RequestPresentationTimeForNextFrame in compositor, which makes it possible to measure the latency. But we are missing the time_stamp of the key event when calling the function to init the UI views, e.g. toggle the app list Launcher:
https://cs.chromium.org/chromium/src/ash/accelerators/accelerator_controller.cc?l=527&rcl=91d26b6d39214699d5812da0c8772242ec68a679

Is it a good idea to save the time_stamp in ui::Accelerator when it is created from the event? Thanks.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2

commit ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2
Author: wutao <wutao@chromium.org>
Date: Fri Mar 09 18:26:24 2018

Add time stamp to ui::Accelerator.

We want to measure the latency between a key event to the time of the
presentation of next UI frame. However, we do not save the time stamp in
ui::Accelerator.

This cl saves the time stamp information when ui::Accelerator is created
from KeyEvent.

Bug:  817116 
Test: AcceleratorTest and AcceleratorStructTraitsTest
Change-Id: If4812a491e16371cf32adae8d7074232dc3c05d8
Reviewed-on: https://chromium-review.googlesource.com/956526
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542164}
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/accelerator.cc
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/accelerator.h
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/accelerator_unittest.cc
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/mojo/BUILD.gn
[add] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/mojo/DEPS
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/mojo/accelerator.mojom
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/mojo/accelerator_struct_traits.h
[modify] https://crrev.com/ea403cb7ef7ee57ea0f893f2fdbdda0f3f5488c2/ui/base/accelerators/mojo/accelerator_struct_traits_unittest.cc

Comment 2 by wutao@chromium.org, Mar 9 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment