New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817115 link

Starred by 2 users
Status: Fixed
Owner:
█ jhawkins@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

SmartLock: Make source CrOS only

Project Member Reported by jhawkins@chromium.org, Feb 27 2018 
SmartLock is deprecated on non-CrOS and ready to be turned down on any non-CrOS platform (it mostly was already disabled at this point). Removing non-CrOS code will help reason about the feature on the only platform we support it on.

SmartLock is somewhat tangled with screenlockPrivate and easyUnlockPrivate extension APIs, so this set of changes will also make those APIs CrOS only (which is true in practice).

Steps:
1) screenlockPrivate
2) easyUnlockPrivate
3) easy_unlock_* moved to if (is_chromeos) in BUILD.gn
4) Move easy_unlock_* to cros-specific directories higher up
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36abf46723aa0071187ba48a3a81d82f13bf5f4d

commit 36abf46723aa0071187ba48a3a81d82f13bf5f4d
Author: James Hawkins <jhawkins@chromium.org>
Date: Wed Feb 28 16:30:54 2018

Extension API: Move screenLockPrivate API to be CrOS-only.

This is true in practice. This change is the first in a series of
changes to make SmartLock only available on CrOS.

R=jlklein@chromium.org, tbarzic@chromium.org

Bug:  817115 
Test: Existing tests
Change-Id: Idc0e414730d8efb4b36d36071362625e700675e1
Reviewed-on: https://chromium-review.googlesource.com/940448
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539845}
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/browser/signin/easy_unlock_app_manager.cc
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/common/extensions/api/_api_features.json
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/36abf46723aa0071187ba48a3a81d82f13bf5f4d/chrome/test/BUILD.gn

Comment 2 by jhawkins@chromium.org, Feb 28 2018

Components: -UI>SignIn UI>SmartLock
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/878a6bb6de52ada7ae31116f934dfbb26a527750

commit 878a6bb6de52ada7ae31116f934dfbb26a527750
Author: James Hawkins <jhawkins@chromium.org>
Date: Thu Mar 01 01:10:14 2018

Extension API: Move easyUnlockPrivate API to be CrOS-only.

This is true in practice and is the next step in making SmartLock
CrOS-only.

Bug:  817115 
Test: Existing tests
Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5
Reviewed-on: https://chromium-review.googlesource.com/940538
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539965}
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/BUILD.gn
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/signin/easy_unlock_app_manager.cc
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/signin/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/signin/easy_unlock_service_factory.cc
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/878a6bb6de52ada7ae31116f934dfbb26a527750/chrome/test/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/441743f6b890929853094469e460db14cec62c98

commit 441743f6b890929853094469e460db14cec62c98
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Mar 01 01:25:09 2018

Revert "Extension API: Move easyUnlockPrivate API to be CrOS-only."

This reverts commit 878a6bb6de52ada7ae31116f934dfbb26a527750.

Reason for revert: Caused build error
https://ci.chromium.org/buildbot/chromium/Linux%20x64/59639

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F59639%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

In file included from ../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate_stub.cc:6:
../../chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_crypto_delegate.h:12:10: fatal error: 'chrome/common/extensions/api/easy_unlock_private.h' file not found
#include "chrome/common/extensions/api/easy_unlock_private.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> Extension API: Move easyUnlockPrivate API to be CrOS-only.
> 
> This is true in practice and is the next step in making SmartLock
> CrOS-only.
> 
> Bug:  817115 
> Test: Existing tests
> Change-Id: I38560b7d35859f65148a6a6cbbb9e4a66e7955a5
> Reviewed-on: https://chromium-review.googlesource.com/940538
> Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Toni Barzic <tbarzic@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539965}

TBR=tbarzic@chromium.org,jhawkins@chromium.org,lazyboy@chromium.org,benwells@chromium.org,karandeepb@chromium.org

Change-Id: Ib5425ec7d3c9283a6fcb776a11c6a1a2f6b61efe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  817115 
Reviewed-on: https://chromium-review.googlesource.com/942421
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539969}
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/BUILD.gn
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/signin/easy_unlock_app_manager.cc
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/signin/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/signin/easy_unlock_service_factory.cc
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/441743f6b890929853094469e460db14cec62c98/chrome/test/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/702b22019eb1532741b359760ed8222c013d27ec

commit 702b22019eb1532741b359760ed8222c013d27ec
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Mar 02 19:56:44 2018

RELAND: Extension API: Move easyUnlockPrivate API to be CrOS-only.

This is true in practice and is the next step in making SmartLock
CrOS-only.

This CL fixes a build issue revealed by clobber build.

Bug:  817115 
Test: Existing tests
Change-Id: I67c18d84a3d4be610acf9c5f5eb5ce36f8b65c53
Reviewed-on: https://chromium-review.googlesource.com/944747
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540592}
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/BUILD.gn
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/extensions/browser_context_keyed_service_factories.cc
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/signin/easy_unlock_app_manager.cc
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/signin/easy_unlock_auth_attempt_unittest.cc
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/signin/easy_unlock_service_factory.cc
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/common/extensions/api/BUILD.gn
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/702b22019eb1532741b359760ed8222c013d27ec/chrome/test/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d1dc7e04da9cd0045989d927f117839d6c7257f

commit 1d1dc7e04da9cd0045989d927f117839d6c7257f
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri Mar 02 22:11:54 2018

SmartLock: Make feature implementation CrOS-only.

A follow-up CL will move the source files into chrome/browser/chromeos/signin.

Bug:  817115 
Test: Existing tests
Change-Id: If4d47bfc1109d9b1b030d70e6e7b2fa3d7b3dbcf
Reviewed-on: https://chromium-review.googlesource.com/942041
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540655}
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/BUILD.gn
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_app_manager_unittest.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_auth_attempt.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_notification_controller.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_service.h
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_service_factory.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/1d1dc7e04da9cd0045989d927f117839d6c7257f/chrome/browser/signin/easy_unlock_service_regular.h
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f8a719789510db188b29c0c6f09704068a302a

commit 90f8a719789510db188b29c0c6f09704068a302a
Author: Daniel Bratell <bratell@opera.com>
Date: Sat Mar 03 14:42:33 2018

Compile fix: Remove chrome_proximity_auth_client.cc

chrome_proximity_auth_client.cc uses easy_unlock_service which
was just moved to be ChromeOS only so chrome_proximity_auth_client.cc
needs to be as well.

If it's compiled and not completely ignored by the linker (most of
the time but not in jumbo builds), it will break the build.

TBR=jhawkins@chromium.org

Bug:  817115 
Change-Id: I606cf0958beb6a736bf0717471a6542adde4dc73
Reviewed-on: https://chromium-review.googlesource.com/947962
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#540751}
[modify] https://crrev.com/90f8a719789510db188b29c0c6f09704068a302a/chrome/browser/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5330caefca2ea140467214d2ac68eb714c8a3bc0

commit 5330caefca2ea140467214d2ac68eb714c8a3bc0
Author: James Hawkins <jhawkins@chromium.org>
Date: Mon Mar 05 21:00:28 2018

SmartLock: Move easy_unlock implementation to CrOS directory.

Bug:  817115 
Test: Existing tests
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: Id47751ab67ffa8cbedd3156657febee6ca84dd0a
Reviewed-on: https://chromium-review.googlesource.com/947583
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540930}
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/BUILD.gn
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_app_manager_unittest.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_auth_attempt_unittest.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_metrics.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos_unittest.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_screenlock_state_handler_unittest.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.h
[add] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_observer.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.h
[rename] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_user_login_flow.h
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/screens/user_selection_screen.h
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[delete] https://crrev.com/a80562ec61f78615e1fc48dc2024623507977ba5/chrome/browser/signin/easy_unlock_service_observer.h
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler_unittest.cc
[modify] https://crrev.com/5330caefca2ea140467214d2ac68eb714c8a3bc0/chrome/test/BUILD.gn

Comment 9 by jhawkins@chromium.org, Mar 30 2018

Status: Fixed (was: Started)
►

Sign in to add a comment