New issue
Advanced search Search tips

Issue 817110 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Some gpu pixel tests need golden images update in order to land Skia's Delta Anti-Aliasing

Project Member Reported by liyuqian@google.com, Feb 27 2018

Issue description

Specifically, they're:

* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasAccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasAccelerated2DWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2D
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DGPUCompositing
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DGPUCompositingWorker
* gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvasUnaccelerated2DWorker
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70f9b617c224affa1e4e1522fa1dc093f9316871

commit 70f9b617c224affa1e4e1522fa1dc093f9316871
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Mar 08 14:39:25 2018

Increment the revision number of GPU pixel tests

Bug: chromium:817110
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If267c55bba4880319dbd171b21663928ebc24d20
Reviewed-on: https://chromium-review.googlesource.com/952708
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541792}
[modify] https://crrev.com/70f9b617c224affa1e4e1522fa1dc093f9316871/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4f4db697ab211ba754072bf200fa1e841df748

commit dc4f4db697ab211ba754072bf200fa1e841df748
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Mar 08 22:32:04 2018

Remove failed expectations and update pixel tests

Bug: chromium:817110
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id2ccbca1f9ddc2f1073fd0532eb06fd335b98f0a
Reviewed-on: https://chromium-review.googlesource.com/956034
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541906}
[modify] https://crrev.com/dc4f4db697ab211ba754072bf200fa1e841df748/content/test/gpu/gpu_tests/pixel_expectations.py

Status: Started (was: Untriaged)
We need to update those pixel tests again to land 976622
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/200e5ec9589da39c634f96b7f5d903c801c8d330

commit 200e5ec9589da39c634f96b7f5d903c801c8d330
Author: Yuqian Li <liyuqian@google.com>
Date: Fri Apr 06 22:14:32 2018

Increment the revision number of GPU pixel tests

Bug: chromium:817110
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I66a5eb870f340812776ca2d1013aaf107c44c56d
Reviewed-on: https://chromium-review.googlesource.com/995643
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548947}
[modify] https://crrev.com/200e5ec9589da39c634f96b7f5d903c801c8d330/content/test/gpu/gpu_tests/pixel_test_pages.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef2c858ec42068bc4b6453bde94460f3b204c84

commit 2ef2c858ec42068bc4b6453bde94460f3b204c84
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Apr 12 01:23:07 2018

Remove failed expectations and update pixel tests

Bug: chromium:817110
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I184faae3ff12d8a23f6e5c12e43c92f1899f54c4
Reviewed-on: https://chromium-review.googlesource.com/1005297
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549993}
[modify] https://crrev.com/2ef2c858ec42068bc4b6453bde94460f3b204c84/content/test/gpu/gpu_tests/pixel_expectations.py

Sign in to add a comment