New issue
Advanced search Search tips

Issue 817104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Make WebGestureEvent coordiantes private

Project Member Reported by eirage@chromium.org, Feb 27 2018

Issue description

TODO: in WebGestureEvent: Make these coordinates private & fractional, as in WebMouseEvent.h 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1116059d3f918982cc5fb669d5ddea17b6172849

commit 1116059d3f918982cc5fb669d5ddea17b6172849
Author: Ella Ge <eirage@chromium.org>
Date: Wed Mar 21 02:06:13 2018

Make WebGestureEvent coords and device private

This CL changes WebGestureEvent coordinates to private and float
to match other Web* class e.g. WebMouseEvent.

x, y -> position_in_widget_
global_x, global_y -> position_in_screen_

This also changes source_device to private source_device_.
Add set source_device_ in constructor, and add setter and getter.
SetSourceDevice will be eliminated in future CL (should be set in constructor)

Bug:  817104 
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iea504fdf4ef1c66610e221343031a6b0f38e7a04
Reviewed-on: https://chromium-review.googlesource.com/953655
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544619}
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/chrome/browser/android/vr/android_ui_gesture_target.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/chrome/browser/vr/content_input_delegate.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/android/gesture_listener_manager.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/fling_controller.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/fling_controller.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/fling_controller_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/gesture_event_queue.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/gesture_event_queue_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/input_router_impl.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/legacy_input_router_impl.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/legacy_input_router_impl_perftest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/legacy_input_router_impl_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/touch_action_filter.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/touch_emulator.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/web_input_event_builders_android.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/web_input_event_builders_android.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/web_input_event_util_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/overscroll_controller.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_input_event_router_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_cocoa.mm
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/renderer_host/render_widget_targeter.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/site_per_process_hit_test_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/common/input/event_with_latency_info_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/common/input/gesture_event_stream_validator.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/common/input/input_event_stream_validator.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/common/input/input_event_struct_traits.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/common/input/input_param_traits_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/public/test/render_view_test.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/renderer/render_widget.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/renderer/render_widget_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/shell/test_runner/event_sender.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/shell/test_runner/event_sender.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/content/shell/test_runner/test_plugin.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/LayoutTests/plugins/transformed-events-expected.txt
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/events/WebInputEventConversionTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/exported/WebPluginContainerImpl.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/exported/WebPluginContainerTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/frame/BrowserControlsTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/frame/VisualViewportTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/input/ImeOnFocusTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/input/OverscrollBehaviorTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/input/ScrollSnapTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/page/scrolling/RootScrollerTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/page/scrolling/ScrollMetricsTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/core/paint/LinkHighlightImplTest.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/platform/WebGestureEvent.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/platform/WebMouseEvent.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/Source/platform/scroll/Scrollbar.cpp
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/public/platform/WebGestureEvent.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/public/platform/WebPointerProperties.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/third_party/WebKit/public/web/WebActiveFlingParameters.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/fling_booster.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/fling_booster_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/input_scroll_elasticity_controller_unittest.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/web_input_event_traits.cc
[modify] https://crrev.com/1116059d3f918982cc5fb669d5ddea17b6172849/ui/events/blink/web_input_event_traits_unittest.cc

Comment 2 by eirage@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment