Showing an interstitial when the blocked URL list changes doesn't work for committed interstitials. |
||||
Issue descriptionURLFilterCheckCallback on SupervisedUserNavigationObserver needs to be adapted to handle the case where the URL Filter changes and the current page is blocked, while committed interstitials are enabled
,
Feb 27 2018
,
Mar 16 2018
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e9b6065509e585335fb6518d587ef87ae2d22bc commit 2e9b6065509e585335fb6518d587ef87ae2d22bc Author: Carlos IL <carlosil@chromium.org> Date: Wed Mar 28 20:52:22 2018 Enabled URL Filter Change Callback for supervised user CI. With committed interstitials on, if the URL filter changes to block the current URL, the site will now reload, causing an interstitial to appear. Also reenabled (and adapted) tests that rely on this functionality. Bug: 817101 Change-Id: Ib7afec1f703216ce1809048cb1bc3416acaf17ae Reviewed-on: https://chromium-review.googlesource.com/965026 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546591} [modify] https://crrev.com/2e9b6065509e585335fb6518d587ef87ae2d22bc/chrome/browser/supervised_user/supervised_user_browsertest.cc [modify] https://crrev.com/2e9b6065509e585335fb6518d587ef87ae2d22bc/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
,
Mar 28 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by carlosil@chromium.org
, Feb 27 2018