New issue
Advanced search Search tips

Issue 817099 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 780023



Sign in to add a comment

Supervised User Committed Interstitials should have JS bindings for Go back and Request Permission.

Project Member Reported by carlosil@chromium.org, Feb 27 2018

Issue description

Similar to SSL Committed interstitials, Supervised User committed interstitials need bindings to perform actions from the interstitial, specifically for 'Request Permission' and 'Go Back'. Browser Tests that use those commands should also be re-enabled.
 
Blocking: 780023
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88a3f388fab5d15a8d69e0d673af8c144779d32d

commit 88a3f388fab5d15a8d69e0d673af8c144779d32d
Author: Carlos IL <carlosil@chromium.org>
Date: Tue Mar 13 17:54:46 2018

Added mojo interface for supervised user commands.

Added mojo interface to handle interstitial commands and implemented it
in SupervisedUserNavigationObserver which passes the commands to
SupervisedUserInterstitial when committed interstitials are enabled.

In a future CL an extra class will be added which will listen to JS
commands from the interstitial and passes them via mojo to the
observer.

Bug:  817099 
Change-Id: I5285e1fdaa16ee4e96ec7167d470b8ada9b73685
Reviewed-on: https://chromium-review.googlesource.com/950413
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542848}
[modify] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/browser/BUILD.gn
[modify] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/browser/supervised_user/supervised_user_interstitial.h
[modify] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/browser/supervised_user/supervised_user_navigation_observer.h
[modify] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/browser/supervised_user/supervised_user_navigation_throttle.cc
[modify] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/common/BUILD.gn
[add] https://crrev.com/88a3f388fab5d15a8d69e0d673af8c144779d32d/chrome/common/supervised_user_commands.mojom

Cc: carlosil@chromium.org est...@chromium.org
 Issue 780037  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/969e5349bda2098624805e7b399cc6be2b4d154a

commit 969e5349bda2098624805e7b399cc6be2b4d154a
Author: Carlos IL <carlosil@chromium.org>
Date: Wed Mar 28 19:24:19 2018

Added bindings for committed supervised user interstitials.

Bug:  817099 
Change-Id: If05efdf9a1a4d50e430ee5541e51bc45b8fd18d9
Reviewed-on: https://chromium-review.googlesource.com/963796
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546560}
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/browser/supervised_user/supervised_user_browsertest.cc
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/browser/supervised_user/supervised_user_interstitial.h
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/browser/supervised_user/supervised_user_navigation_observer.h
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/common/supervised_user_commands.mojom
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/BUILD.gn
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/net/net_error_helper.h
[add] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/supervised_user/OWNERS
[add] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/supervised_user/supervised_user_error_page_controller.cc
[add] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/supervised_user/supervised_user_error_page_controller.h
[add] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/chrome/renderer/supervised_user/supervised_user_error_page_controller_delegate.h
[modify] https://crrev.com/969e5349bda2098624805e7b399cc6be2b4d154a/components/supervised_user_error_page/resources/supervised_user_block_interstitial.js

Status: Fixed (was: Started)

Sign in to add a comment