New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817094 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 721401



Sign in to add a comment

Refactor google_apis/gcm/engine/connection_factory_impl.cc to using services/network/proxy_resolving_client_socket.cc

Project Member Reported by xunji...@chromium.org, Feb 27 2018

Issue description

As a part of network servicification, we are reducing our API surface so we can migrate embedders of //net to Network Service's mojo APIs.

connection_factory_impl.cc duplicates a lot of logic from http_stream_factory_impl_job.cc and uses net::InitSocketHandleForTlsConnect to access socket pools. 

We need to refactor it to using services/network/proxy_resolving_client_socket.cc.

Details can be found in this doc:
https://docs.google.com/document/d/1iQl_Y2o7vykiPXpZiNbKov-WZbUb4RprmXIk311tTso/edit
 
Labels: -Pri-3 M-67 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/125d56484ba5b55bb7b59c3b1b48464ae3a95931

commit 125d56484ba5b55bb7b59c3b1b48464ae3a95931
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Mar 07 19:08:01 2018

Update retryable errors in proxy_resolving_client_socket.cc when connect to proxy failed.

This CL removes the special case in proxy_resolving_client_socket.cc to not skip
retryable errors when connect to proxy fails.

Bug:  817094 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I664a4b8926b73afc44480b240ad3b0b6e5446ad0
Reviewed-on: https://chromium-review.googlesource.com/952986
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541520}
[modify] https://crrev.com/125d56484ba5b55bb7b59c3b1b48464ae3a95931/services/network/proxy_resolving_client_socket.cc
[modify] https://crrev.com/125d56484ba5b55bb7b59c3b1b48464ae3a95931/services/network/proxy_resolving_client_socket_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9

commit 345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Mar 20 21:47:01 2018

Switch gcm connection_factory_impl.cc to using services/network/proxy_resolving_client_socket.h

This CL migrates gcm to using proxy_resolving_client_socket.h/cc.

As a part of network servicification, we are reducing the //net's API surface.
connection_factory_impl.cc calls into static
net::InitSocketHandleForTlsConnect(), which will not be exposed by network
service. This CL migrates gcm off that static function.

Bug:  817094 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If5a6df107603c676412b971a3d74284a1d01cfc0
Reviewed-on: https://chromium-review.googlesource.com/952333
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Nicolas Zea (slow) <zea@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544537}
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/google_apis/gcm/DEPS
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/google_apis/gcm/engine/connection_factory_impl.h
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/jingle/glue/xmpp_client_socket_factory.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/net/socket/client_socket_pool_manager.h
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/net/socket/socket_test_util.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/net/socket/socket_test_util.h
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/remoting/signaling/xmpp_signal_strategy.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/services/network/proxy_resolving_client_socket.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/services/network/proxy_resolving_client_socket.h
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/services/network/proxy_resolving_client_socket_factory.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/services/network/proxy_resolving_client_socket_factory.h
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/services/network/proxy_resolving_client_socket_unittest.cc
[modify] https://crrev.com/345f95ae2cab6f198cb3c2a57a0f0221afe1f3a9/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment