New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817091 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.w.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 27 2018

Issue description

"external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.w.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 10 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllleHRlcm5hbC93cHQvb2Zmc2NyZWVuLWNhbnZhcy90aGUtb2Zmc2NyZWVuLWNhbnZhcy9vZmZzY3JlZW5jYW52YXMuY29udmVydC50by5ibG9iLncuaHRtbAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Feb 28 2018

Detected 12 new flakes for test/step "external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.w.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZAsSBUZsYWtlIllleHRlcm5hbC93cHQvb2Zmc2NyZWVuLWNhbnZhcy90aGUtb2Zmc2NyZWVuLWNhbnZhcy9vZmZzY3JlZW5jYW52YXMuY29udmVydC50by5ibG9iLncuaHRtbAw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Mar 7 2018

Cc: stale-flakes-reports@google.com
Reporting to stale-flakes-reports@google.com to investigate why this issue is not being processed despite being in an appropriate queue for 7 days or more.
Components: Blink>Canvas
Labels: -Sheriff-Chromium

Comment 4 by junov@chromium.org, Mar 9 2018

Owner: xlai@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by xlai@chromium.org, Mar 14 2018

 Issue 813462  has been merged into this issue.

Comment 6 by xlai@chromium.org, Mar 14 2018

Cc: -stale-flakes-reports@google.com foolip@chromium.org
+cc foolip@ (owner of LayoutTests/external) for help: 
Is there a way to let the layout tests in external/wpt/ folders run with additional driver flags? 
I know that for the usual Layout Tests, we can easily put them in a separate folder and mark it in VirtualTestSuites. Can we do the same for wpt tests?

The reason why I ask this is that these convertToBlob tests must be run in an environment when --enable-threaded-compositing is enabled, as the idle tasks can
only be run with this flag. Otherwise the convertToBlob will be switching to enforce encoding mode after a long waiting time for the idle task to begin. Currently, the rest of toBlob Layout Tests are all running with a flag (see
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/VirtualTestSuites?l=21).

Comment 7 by foolip@chromium.org, Mar 14 2018

Yes, you can use VirtualTests in the same way, most things are just like LayoutTests. But you can't change the flags for the "non-virtual" configuration so you'll have to manage the duplication of coverage, possibly by skipping tests that aren't meaningful to run.

Comment 8 by xlai@chromium.org, Mar 15 2018

Status: Started (was: Assigned)
Thanks foolip@. CL waiting to be reviewed: https://chromium-review.googlesource.com/c/chromium/src/+/964395
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4282c508e7618f5999450ddf2e0ece2bb2cf9138

commit 4282c508e7618f5999450ddf2e0ece2bb2cf9138
Author: xlai <xlai@chromium.org>
Date: Mon Mar 19 15:21:08 2018

Improve wpt testing on OffscreenCanvas convertToBlob

Same as canvas.toBlob(), the OffscreenCanvas.convertToBlob() are running on
idle tasks by default. When idle tasks do not begin for a long time, they force
encoding on the current thread. As idle tasks are not enabled on layout tests
unless "--enable-threaded-compositing" flag is turned on, we therefore do both
virtual and non-virtual tests to ensure complete test coverage of both
execution paths--idle-task mode and force-encoding mode. The non-virtual tests
need to be marked as [Slow] as the CanvasAsyncBlobCreator is waiting for the
idle tasks for a threshold time before switching to force-encoding mode.

Bug:  817091 
Change-Id: I2c7da9e27ee2d24e1a5e6ee1c36597b46f052aca
Reviewed-on: https://chromium-review.googlesource.com/964395
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544036}
[modify] https://crrev.com/4282c508e7618f5999450ddf2e0ece2bb2cf9138/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/4282c508e7618f5999450ddf2e0ece2bb2cf9138/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4282c508e7618f5999450ddf2e0ece2bb2cf9138/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/4282c508e7618f5999450ddf2e0ece2bb2cf9138/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.html
[rename] https://crrev.com/4282c508e7618f5999450ddf2e0ece2bb2cf9138/third_party/WebKit/LayoutTests/external/wpt/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.w.html
[add] https://crrev.com/4282c508e7618f5999450ddf2e0ece2bb2cf9138/third_party/WebKit/LayoutTests/virtual/threaded/external/wpt/offscreen-canvas/convert-to-blob/README.txt

Comment 10 by xlai@chromium.org, Mar 20 2018

Status: Fixed (was: Started)
I've watched the Flakiness dashboard and note that both converttoblob WPT tests are all running fine in these past two days.

Sign in to add a comment