https://github.com/w3c/payment-request/pull/672/files
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb commit ea8d662132c47dd3789fe6c67fa1e2d619be9eeb Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Mar 28 15:20:02 2018 [iOS][PR] Add an optional promise to show(). Spec change: https://github.com/w3c/payment-request/pull/672/files Manual tests: 1) https://rsolomakhin.github.io/pr/wait/ 2) https://rsolomakhin.github.io/pr/single-wait/ 3) https://rsolomakhin.github.io/pr/multi-wait/ 4) https://rsolomakhin.github.io/pr/us-wait/ 5) https://rsolomakhin.github.io/pr/ko/reject-show-promise/ 6) https://rsolomakhin.github.io/pr/ko/timeout-show-promise/ 7) https://rsolomakhin.github.io/pr/ko/show-promise-unsupported-method/ 8) https://rsolomakhin.github.io/pr/ko/resolve-show-promise-invalid-details/ Design: go/prshow-details-promise Bug: 817073 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1816a4874ba53a646da26fe2ea4d6e1f9ff41d79 Reviewed-on: https://chromium-review.googlesource.com/975663 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#546488} [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/components/payments/core/BUILD.gn [add] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/components/test/data/payments/payment_request_show_promise.html [add] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/components/test/data/payments/show_promise.js [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/payments/payment_request.h [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/payments/payment_request.mm [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_items_display_view_controller.mm [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_coordinator.mm [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_manager.mm [add] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_show_egtest.mm [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_view_controller.mm [modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/web/resources/payment_request.js
Comment 1 by rouslan@chromium.org
, Mar 1 2018