New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817073 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 817807



Sign in to add a comment

PaymentRequest.show() should optionally take a promise

Project Member Reported by rouslan@chromium.org, Feb 27 2018

Issue description

Blocking: 817807
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb

commit ea8d662132c47dd3789fe6c67fa1e2d619be9eeb
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Mar 28 15:20:02 2018

[iOS][PR] Add an optional promise to show().

Spec change:
https://github.com/w3c/payment-request/pull/672/files

Manual tests:
1) https://rsolomakhin.github.io/pr/wait/
2) https://rsolomakhin.github.io/pr/single-wait/
3) https://rsolomakhin.github.io/pr/multi-wait/
4) https://rsolomakhin.github.io/pr/us-wait/
5) https://rsolomakhin.github.io/pr/ko/reject-show-promise/
6) https://rsolomakhin.github.io/pr/ko/timeout-show-promise/
7) https://rsolomakhin.github.io/pr/ko/show-promise-unsupported-method/
8) https://rsolomakhin.github.io/pr/ko/resolve-show-promise-invalid-details/

Design: go/prshow-details-promise
Bug: 817073
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1816a4874ba53a646da26fe2ea4d6e1f9ff41d79
Reviewed-on: https://chromium-review.googlesource.com/975663
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546488}
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/components/payments/core/BUILD.gn
[add] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/components/test/data/payments/payment_request_show_promise.html
[add] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/components/test/data/payments/show_promise.js
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/payments/payment_request.h
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/payments/payment_request.mm
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/BUILD.gn
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_items_display_view_controller.mm
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_coordinator.mm
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_manager.mm
[add] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_show_egtest.mm
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/ui/payments/payment_request_view_controller.mm
[modify] https://crrev.com/ea8d662132c47dd3789fe6c67fa1e2d619be9eeb/ios/chrome/browser/web/resources/payment_request.js

Sign in to add a comment