Compositing.Renderer.RasterTask.RasterUs.{Software,Gpu} are erroneously obsolete |
||||||
Issue descriptionIf you navigate to UMA, and select one of Compositing.Renderer.RasterTask.RasterUs.Gpu or Compositing.Renderer.RasterTask.RasterUs.Software histograms, there's a message that says "Obsolete: Deprecated as of 02/2018. Using suffix Gpu and Software instead." which also prevents this histogram from showing up in the autocomplete list. I think this is in error, since those histograms are using the appropriate suffixes and are not obsolete.
,
Feb 27 2018
I think i have caused it in my cl. Thank you for reporting it.
,
Feb 27 2018
The changelist looks right. Filed dashboard bug at b/73963900
,
Feb 27 2018
The issue is that we do not correctly handle marking an empty histogram suffix as obsolete. What happens is that we mark the original histogram as obsolete, and then propagate this down to the children: https://cs.chromium.org/chromium/src/tools/metrics/histograms/extract_histograms.py?l=455-456,503-506&rcl=ba2757891a9408f2e39a938097d4bbc9ec9c67f8 This could either be fixed by removing the empty histogram suffix and marking the base histograms as base="true" (or just marking marking the empty suffix as base="true", sans the <obsolete> note)... or by fixing the extract_histograms.py script. I don't have a great idea offhand for a quick fix to the script – it's kind of a pile of accumulated quick fixes, and I think we should probably rewrite the logic... but that's not a task I can pick up right now. If anyone else wants to pick it up, or wants to write a quick fix, please do! (One half-baked idea might be to process empty suffixes last in the list of suffixes. I haven't fully thought through how well this would work in practice, e.g. whether this runs into any issues with stacked suffixes. I'm also not sure how to implement that cleanly – though it could certainly be hacked in =])
,
Feb 27 2018
Oh, and: If we do fix up extract_histograms.py, we'll want to make the same change in the google3 repository. I'll gladly make and land said patch if someone else picks up the Chromium side of the work =)
,
Feb 28 2018
,
Feb 28 2018
Thank you Mark and Ilya for diving into the problem. It sounds like the bug is not on my side and it's in the histogram. I don't really want to remove the empty histogram suffix as it has reported useful data in the past.
,
Feb 28 2018
,
Aug 16
Am I right in thinking that we should only be looking at the Compositing.Renderer.RasterTask.RasterUs.Gpu and Compositing.Renderer.RasterTask.RasterUs.Software metrics, and not Compositing.Renderer.RasterTask.RasterUs? The latter is spewing out finch warnings about no data or very low data counts. I could file a bug for the finch alerts, but first I want to be sure that the behavior is unexpected. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vmp...@chromium.org
, Feb 27 2018