[WPT Import] Importer does not handle CQ+2 failures correctly |
||
Issue descriptionWhen an import CL passes CQ dry run but fails to be submitted (e.g. last-minute merge conflicts), importer doesn't see the failures and considers the import successful (which then leads to bugs to be filed by the notifier, even though nothing is imported).
,
Mar 4 2018
Bumping to P2 as this has happened again within the week. And it should be easy to fix :)
,
May 3 2018
Do you have an update @robertma :)
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e665d5f61e0558ef0b3dfe5029152f237ad9618 commit 1e665d5f61e0558ef0b3dfe5029152f237ad9618 Author: Robert Ma <robertma@chromium.org> Date: Wed May 30 21:39:41 2018 [WPT import] Handle CQ+2 failures Sometimes CQ+2 can fail even when CQ+1 succeeds (e.g. last-minute merge conflicts). This CL catches this failure properly. Bug: 817025 Change-Id: Ic6679a7b4797132abd3ecae348644d6e14f73c7c Reviewed-on: https://chromium-review.googlesource.com/1079889 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#563007} [modify] https://crrev.com/1e665d5f61e0558ef0b3dfe5029152f237ad9618/third_party/blink/tools/blinkpy/w3c/test_importer.py [modify] https://crrev.com/1e665d5f61e0558ef0b3dfe5029152f237ad9618/third_party/blink/tools/blinkpy/w3c/test_importer_unittest.py
,
May 30 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by robertma@chromium.org
, Mar 4 2018Owner: robertma@chromium.org
Status: Assigned (was: Available)