New issue
Advanced search Search tips

Issue 817013 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug


Participants' hotlists:
pbos-backlog


Sign in to add a comment

Windows Chrome document associations look like copies of Chrome

Project Member Reported by pbos@chromium.org, Feb 27 2018

Issue description

grt@ can you gauge how difficult this would be to address? Which icons / DPI sizes etc. would be needed? Just one per channel? I think this icon association is created by the installer here:

https://cs.chromium.org/chromium/src/chrome/installer/util/shell_util.cc?rcl=92164ac330c9291b73d7638b79279be69c316380&l=376

Attaching screenshot of a PDF file on my desktop (Win10) that just looks like another copy of Chrome. Ideally it should look like a document icon that has the chrome icon inside it (meaning that we need corresponding copies for stable,beta,dev,canary).
 

Comment 1 by pbos@chromium.org, Feb 27 2018

chrome-doc-icon.png
6.0 KB View Download

Comment 2 by grt@chromium.org, Feb 28 2018

I think this is quite related to issue 653576. Basically, I think the right thing to do would be to register different progids for various file associations so that each could have a distinct name and icon. Or maybe just one generic "a document opened by Chrome" icon that isn't the same as Chrome's product icon.

I think it should follow the same requirements as the main product icon (theme/google_chrome/win/chrome.ico).

Comment 3 by pbos@chromium.org, Feb 28 2018

Cc: gab@chromium.org
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
I don't think we should necessarily get in the habit of providing N different icons (maybe N names are fine though) since those are diminishing returns.

I think the latter is low-effort enough, with a generic chrome-document logo. I'll see if we can get document icons for these. "Chrome HTML document" has always bothered me as there's nothing Chrome-specific in the filetype itself, it's just handled by Chrome.

As this string shows up for both files and protocols like irc:// another viable string would be "Handled by Chrome", as I think it shows as "Type: Handled by Chrome". This would cover both protocol and document. Not sure if other surfaces would make this style violation blatant, and translations might not perfectly cover it either, but I think both of these would be a large improvement on the current state of things.

+gab@ FYI / if you have strong opinions on making the protocol-handler cases better. If we change the default file-association icon I believe irc:// with Chrome as a protocol handler would show a document icon.

Comment 4 by pbos@chromium.org, Apr 19 2018

Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment