Build Notifications for CrOS MultiDevice unified setup |
|||
Issue descriptionBuild Notifications for CrOS MultiDevice unified setup. Add notification framework following the model of TetherNotificationPresenter (see chrome/browser/ui/ash/network/tether_notification_presenter.h) and its parent NotificationPresenter (see chromeos/components/tether/notification_presenter.h) to display the necessary notifications. The new parent class code will live in a new directory, chromeos/components/multidevice_setup, which is in progress in Chromium CL 938744.
,
Feb 27 2018
,
Mar 12 2018
Note that the new directory has since been built but there is a substantial refactor underneath by khorimoto in https://chromium-review.googlesource.com/c/chromium/src/+/954010
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73de9a89f558c8f573dc881cbab3c42eb04618a8 commit 73de9a89f558c8f573dc881cbab3c42eb04618a8 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Tue Apr 10 01:16:39 2018 [CrOS MultiDevice] Add notifications for unified MultiDevice setup. The meat of the CL is in the multidevice_notification_presenter files which requires a few supplementary sub-tasks: 1) Hardcoding notification titles and messages in ash/ash_strings.grd 2) Creating and incorporating Better Together vector icons 3) Adding metrics. Bug: 816992 Change-Id: Ia6f920a83688247509b9de01d2527f89990d2368 Reviewed-on: https://chromium-review.googlesource.com/950402 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#549359} [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/BUILD.gn [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/DEPS [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/ash_strings.grd [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/message_center/message_center_controller.cc [add] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/multi_device_setup/multi_device_notification_presenter.cc [add] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/multi_device_setup/multi_device_notification_presenter.h [add] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/multi_device_setup/multi_device_notification_presenter_unittest.cc [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/public/cpp/vector_icons/BUILD.gn [add] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/ash/public/cpp/vector_icons/notification_multi_device_setup.icon [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/tools/metrics/histograms/enums.xml [modify] https://crrev.com/73de9a89f558c8f573dc881cbab3c42eb04618a8/tools/metrics/histograms/histograms.xml
,
Apr 11 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jordynass@chromium.org
, Feb 27 2018