New issue
Advanced search Search tips

Issue 816987 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Feb 2018
Cc:
bsheedy@chromium.org
cjgrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: UI will not show if assets fail to load

Project Member Reported by tiborg@chromium.org, Feb 27 2018 
Currently, if loading the assets file fail we silently return and continue to hide the UI (see https://cs.chromium.org/chromium/src/chrome/browser/vr/ui.cc?rcl=51465ffac6b1f9cd1b728ebd20eec0566c91fafe&l=393). Instead, we should show the fallback.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db5ac93db553803d0b2a85088ea80c586f4d394

commit 2db5ac93db553803d0b2a85088ea80c586f4d394
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Feb 27 23:25:03 2018

[vr] Show fallback background if assets fail to load

Bug:  816987 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If1eac6d37494a90463397225ccf51d56326df599
Reviewed-on: https://chromium-review.googlesource.com/940184
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539576}
[modify] https://crrev.com/2db5ac93db553803d0b2a85088ea80c586f4d394/chrome/browser/vr/ui.cc

Comment 2 by tiborg@chromium.org, Feb 27 2018

Status: Fixed (was: Assigned)

Comment 3 by dougman@chromium.org, Feb 28 2018

Labels: Test-Complete
This can be tested on a rooted device by removing one of the asset files.
Added Test case to "VR Browsing: Assets Component Testing Plan"
Testcase: P2 | Loading asset file fails

Verified with build 66.0.3357.0 canary.
►

Sign in to add a comment