Under-specified dependencies around public/platform/modules/fetch/fetch_api_request.mojom-shared.h" |
||||
Issue description
Just got this locally:
In file included from ../../third_party/WebKit/Source/platform/loader/testing/MockResource.cpp:5:
In file included from ../../third_party/WebKit/Source/platform/loader/testing/MockResource.h:9:
In file included from ../../third_party/WebKit/Source/platform/loader/fetch/Resource.h:43:
../../third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h(43,10): fatal error: 'public/platform/modules/fetch/fetch_api_request.mojom-shared.h' file not found
#include "public/platform/modules/fetch/fetch_api_request.mojom-shared.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.cpp:9:
In file included from ../../third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h:10:
In file included from ../../third_party/WebKit/Source/platform/loader/fetch/FetchContext.h:38:
In file included from ../../third_party/WebKit/Source/platform/loader/fetch/FetchParameters.h:34:
../../third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h(43,10): fatal error: 'public/platform/modules/fetch/fetch_api_request.mojom-shared.h' file not found
#include "public/platform/modules/fetch/fetch_api_request.mojom-shared
Looks like the targets containing these cpp file miss a dep on the mojo generator rule.
That include was touched in https://chromium.googlesource.com/chromium/src/+/458b9132f3d40790e848d3b7dbca6d4c67d4893f
,
Feb 28 2018
loader/test_support should have //third_party/WebKit/public:mojo_bindings_blink or //third_party/WebKit/Source/platform/blink_platform_public_deps in public_deps? Let me try.
,
Feb 28 2018
Failed to have a quick fix. My plan of #2 causes other undefined symbols on mojo traits.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d798bde23a6ca66ee24a708732435c037d960b4a commit d798bde23a6ca66ee24a708732435c037d960b4a Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Mar 02 10:25:00 2018 Speculative fix for missing GN dependencies in platform/loader Bug: 816984 Change-Id: If919ac87d19dca87f5846b70db8f96c3f99bd7f9 Reviewed-on: https://chromium-review.googlesource.com/940384 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540485} [modify] https://crrev.com/d798bde23a6ca66ee24a708732435c037d960b4a/third_party/WebKit/Source/platform/loader/BUILD.gn
,
Mar 4 2018
Feel free to reopen this issue if it's still happening. |
||||
►
Sign in to add a comment |
||||
Comment 1 by yhirano@chromium.org
, Feb 28 2018