New issue
Advanced search Search tips

Issue 816976 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 808284



Sign in to add a comment

When the signal strength is unavailable, return the most conservative cached network quality

Project Member Reported by tbansal@chromium.org, Feb 27 2018

Issue description

When the signal strength for the current network is unavailable, currently, the network quality store returns the first cached value that has the same network ID as the current one. This first value may have been recorded when the signal strength was low. This can sometimes cause the network quality store to return very low values of network quality even when the network is fast.

The logic should be updated to return the network quality that's fastest among all cached values. 
 
Blocking: 808284
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d70a5c50a5d8ee8011f2f51ee223bcf79619a5d8

commit d70a5c50a5d8ee8011f2f51ee223bcf79619a5d8
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Feb 28 02:28:34 2018

NQE: Handle cases when signal strength is unavailable

When the signal strength for the current network is unavailable,
return the network quality that's fastest among all
cached values. This ensures that the Network Quality
Estimator (NQE) returns a conservative network quality.

Bug:  816976 
Change-Id: Ie97290f0a1af63b38183cfeee60c5012d1046643
Reviewed-on: https://chromium-review.googlesource.com/938574
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539665}
[modify] https://crrev.com/d70a5c50a5d8ee8011f2f51ee223bcf79619a5d8/net/nqe/network_quality_store.cc
[modify] https://crrev.com/d70a5c50a5d8ee8011f2f51ee223bcf79619a5d8/net/nqe/network_quality_store_unittest.cc

Labels: -Pri-3 Pri-2
Status: Fixed (was: Started)

Sign in to add a comment