Improve Previews whitelist and blacklist checks on committed URLs |
||
Issue descriptionFor crbug.com/787191 , we added a committed URL check using the ShouldAllowPreviewAtECT() interface with EFFECTIVE_CONNECTION_TYPE_LAST to avoid constraining by ECT. This performs more checks and logging than needed. Consider adding a new PreviewsDecider method targetted to just the URL blacklist/whitelist checks desired on the committed URL and use that instead.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02991edfc56a622c1b32803d63b7eccfe0a9c868 commit 02991edfc56a622c1b32803d63b7eccfe0a9c868 Author: Doug Arnett <dougarnett@chromium.org> Date: Wed Feb 28 19:36:30 2018 Adds new PreviewsDecider method to check URL against blacklist/whitelist New interface method PreviewsDecider::IsURLAllowedForPreview() checks a URL against the local blacklist and optimization hints whitelist if applicable. This reduced check is now used on the committed URL for NoScript (refactor from using ShouldAllowPreviewAtEct() at commit time). This reduces the preview logging cruft that the current commit time check adds. Bug: 816964 Change-Id: I2e81d06d3397cd3f3f7727f658ee8818c22e122c Reviewed-on: https://chromium-review.googlesource.com/922459 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#539925} [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/chrome/browser/offline_pages/offline_page_request_job_unittest.cc [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/content/previews_content_util.cc [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/content/previews_content_util_unittest.cc [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/content/previews_io_data.cc [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/content/previews_io_data.h [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/content/previews_io_data_unittest.cc [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/core/previews_decider.h [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/core/test_previews_decider.cc [modify] https://crrev.com/02991edfc56a622c1b32803d63b7eccfe0a9c868/components/previews/core/test_previews_decider.h
,
Mar 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dougarnett@chromium.org
, Feb 27 2018